Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Traffic Control] Improved error metrics and benchmarking #20134

Merged
merged 6 commits into from
Nov 6, 2024

Conversation

williampsmith
Copy link
Contributor

@williampsmith williampsmith commented Nov 1, 2024

Description

  • Add error categorization to the error metrics
  • Added trace logging
  • Set invariant on x-forwarded-for header length vs associated node config setting

Test plan

How did you test the new or updated feature?

Ran on private testnet many times

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 7:15pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 7:15pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 7:15pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 7:15pm

@williampsmith williampsmith temporarily deployed to sui-typescript-aws-kms-test-env November 3, 2024 18:04 — with GitHub Actions Inactive
@williampsmith williampsmith temporarily deployed to sui-typescript-aws-kms-test-env November 3, 2024 20:38 — with GitHub Actions Inactive
@williampsmith williampsmith changed the title [Traffic Control] Improved error metrics [Traffic Control] Improved error metrics and benchmarking Nov 3, 2024
@williampsmith williampsmith temporarily deployed to sui-typescript-aws-kms-test-env November 4, 2024 00:42 — with GitHub Actions Inactive
@williampsmith williampsmith temporarily deployed to sui-typescript-aws-kms-test-env November 6, 2024 01:15 — with GitHub Actions Inactive
@williampsmith williampsmith enabled auto-merge (squash) November 6, 2024 01:16
@williampsmith williampsmith temporarily deployed to sui-typescript-aws-kms-test-env November 6, 2024 01:59 — with GitHub Actions Inactive
@williampsmith williampsmith temporarily deployed to sui-typescript-aws-kms-test-env November 6, 2024 02:03 — with GitHub Actions Inactive
@williampsmith williampsmith temporarily deployed to sui-typescript-aws-kms-test-env November 6, 2024 19:03 — with GitHub Actions Inactive
@williampsmith williampsmith temporarily deployed to sui-typescript-aws-kms-test-env November 6, 2024 19:09 — with GitHub Actions Inactive
@williampsmith williampsmith enabled auto-merge (squash) November 6, 2024 19:09
@williampsmith williampsmith temporarily deployed to sui-typescript-aws-kms-test-env November 6, 2024 19:13 — with GitHub Actions Inactive
@williampsmith williampsmith merged commit 59786ac into main Nov 6, 2024
52 checks passed
@williampsmith williampsmith deleted the william/traffic-categorization branch November 6, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants