test #20017
Draft
test #20017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
joyqvq
force-pushed
the
joy/attestation
branch
from
0a7034c
to
8f86df1
Compare
joyqvq
force-pushed
the
joy/attestation
branch
from
8f86df1
to
90a91c6
Compare
joyqvq
force-pushed
the
joy/attestation
branch
2 times, most recently
from
f056421
to
de1eacd
Compare
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
joyqvq
force-pushed
the
joy/attestation
branch
from
0f9b9a8
to
0a911f0
Compare
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
joyqvq
force-pushed
the
joy/attestation
branch
from
7734654
to
63320e2
Compare
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
joyqvq
force-pushed
the
joy/attestation
branch
from
272320e
to
953eb3a
Compare
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
joyqvq
force-pushed
the
joy/attestation
branch
from
953eb3a
to
2210d13
Compare
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
joyqvq
force-pushed
the
joy/attestation
branch
from
2210d13
to
90a3f3d
Compare
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
joyqvq
force-pushed
the
joy/attestation
branch
from
90a3f3d
to
9c9a1f8
Compare
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
joyqvq
commented
Nov 4, 2024
| // Step 1. Decode the CBOR object and map it to a COSE_Sign1 structure | ||
| let cose_sign1 = CoseSign1::from_bytes(document_data) | ||
| .map_err(|_| SuiError::AttestationFailedToVerify("cannot parse cose sign1".to_string()))?; | ||
| let now = SystemTime::now(); |
There was a problem hiding this comment.
nitro enclave attestation expires in 3 hours. is it safe to use system time now from validators?
There was a problem hiding this comment.
local time is not consistent, we can read Clock on the Move level and pass its value to the native call
joyqvq
commented
Nov 4, 2024
| InvalidUserData, | ||
| } | ||
|
|
||
| impl From<ciborium::de::Error<std::io::Error>> for NitroError { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.