Add a rest endpoint to return checkpoint in batches #19457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
sadhansood
force-pushed
the
sadhan/checkpoint_batching
branch
from
007aff1
to
4c6641d
Compare
bmwill
reviewed
Sep 23, 2024
Comment on lines
+103
to
+105
| fn path(&self) -> &'static str { | ||
| "/checkpoints/full/batch" | ||
| } |
There was a problem hiding this comment.
We probably just want the path to be "/checkpoints/full" to be consistent with the other apis
Comment on lines
+133
to
+135
| pub struct GetCheckpointFullBatchQueryParameters { | ||
| pub start: CheckpointSequenceNumber, | ||
| pub batch_size: u32, |
There was a problem hiding this comment.
Look at the other list apis (checkpoints as an example) to match the param naming
| pub struct GetCheckpointFullBatchQueryParameters { | ||
| pub start: CheckpointSequenceNumber, | ||
| pub batch_size: u32, | ||
| pub max_wait_ms: Option<u64>, |
There was a problem hiding this comment.
As we discussed offline lets punt the long polling till later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a rest endpoint in full node to return full checkpoints in batches. Additionally, it adds a query param to control server side wait timeout if there is no data available to reduce network traffic.