-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
indexer: exclude deleted/wrapped objects from snapshot #19455
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might break a bunch of graphql tests because we expect partial data (ObjectRef) to be available, and we map that to ObjectStatus::WrappedOrDeleted
. Now that we are excluding wrapped/deleted objects from the snapshot, these will yield empty results
@wlmyng thx for the quick review! do I just need to look out and try to fix those tests, or there are real dependencies that we should hold on this change? |
9566e60
to
7988440
Compare
7988440
to
2ea7e97
Compare
The dependency is real today, so the first step would be to remove the references to this kind of information from the GraphQL side. |
@amnn sounds good, I also found a bug while writing this pr, I will split them then. regarding the references removal, do we have linear issue tracking, can we make one if not? |
I don't think so -- feel free to add one. |
2ea7e97
to
071aaf3
Compare
071aaf3
to
9de3f8e
Compare
9de3f8e
to
90ce425
Compare
Description
https://mysten-labs.slack.com/archives/C0578KFD9D2/p1726765436840499
this will cut storage further down
Test plan
objects snapshot ingestion test
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.