Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bridge-indexer] Integrate progress saving policy #19244

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

longbowlu
Copy link
Contributor

@longbowlu longbowlu commented Sep 6, 2024

Description

This PR integrates ProgressSavingPolicy. Basically, sui data sources use OutOfOrderSaveAfterDuration and eth data sources use SaveAfterDuration.

Also changed metric live_task_current_checkpoint to tasks_current_checkpoints to track all tasks in save_progress

Test plan

production deployment


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2024 10:34pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Sep 7, 2024 10:34pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Sep 7, 2024 10:34pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Sep 7, 2024 10:34pm

Copy link
Contributor

@dariorussi dariorussi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Question: I thought the ingestion framework would call save progress only when a contiguous sequence of checkpoint was processed. Is that not the case?
Can you articulate why we need an out of order tracking for the ingestion framwork?

Base automatically changed from progress-saving-policy to main September 7, 2024 06:12
@longbowlu
Copy link
Contributor Author

LGTM. Question: I thought the ingestion framework would call save progress only when a contiguous sequence of checkpoint was processed. Is that not the case? Can you articulate why we need an out of order tracking for the ingestion framwork?

we are talking offline about this

@longbowlu longbowlu force-pushed the integrate-progress-saving-policy branch from 411ec7b to 11f47cc Compare September 7, 2024 22:29
@longbowlu longbowlu merged commit 2616286 into main Sep 7, 2024
49 checks passed
@longbowlu longbowlu deleted the integrate-progress-saving-policy branch September 7, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants