[core] cleanup StateAccumulatorV1 #18764
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
williampsmith
force-pushed
the
william/cleanup-state-accum-v1
branch
from
c64bdf9
to
9bf2ad0
Compare
williampsmith
force-pushed
the
william/cleanup-state-accum-v1
branch
from
9bf2ad0
to
5386b89
Compare
williampsmith
force-pushed
the
william/cleanup-state-accum-v1
branch
from
5386b89
to
3e36e9c
Compare
williampsmith
changed the title
mystenmark
reviewed
Jul 23, 2024
There was a problem hiding this comment.
Is there any possibility anyone had this disabled via config? If so, this could break. The safest possible thing is:
- remove the ability to disable v2 via config
- then merge this PR after that change has gone out
lastly, it might be worth having an assert that v2 is enabled just in case.
williampsmith
force-pushed
the
william/cleanup-state-accum-v1
branch
from
3e36e9c
to
8d33916
Compare
williampsmith
changed the base branch from
main
to
william/make-v1-non-configurable
williampsmith
force-pushed
the
william/cleanup-state-accum-v1
branch
from
8d33916
to
d4c6e25
Compare
8 tasks
williampsmith
added a commit
that referenced
this pull request
Sep 6, 2024
## Description We have removed the ability to disable state accumulator v2 previously by ignoring the config parameter (#18786), however if a node that had v2 disabled has been running since before this change without shutting down, the old config would still be stored in memory. This PR forces enabling of v2. Once we have reached the epoch change after all nodes are running this code, we can safely merge #18764. ## Test plan Existing tests --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
suiwombat
pushed a commit
that referenced
this pull request
Sep 16, 2024
## Description We have removed the ability to disable state accumulator v2 previously by ignoring the config parameter (#18786), however if a node that had v2 disabled has been running since before this change without shutting down, the old config would still be stored in memory. This PR forces enabling of v2. Once we have reached the epoch change after all nodes are running this code, we can safely merge #18764. ## Test plan Existing tests --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove v1, leave v2, rename to just
StateAccumulatorTest plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.