-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mysten-service] 6/n update the sui-services dockerfile with new service #15873
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
I have a general question, if i understand it correctly, we're trying to bake all the binaries into a single docker image, right?
|
@pei-mysten since rust binaries are relatively tiny I planned on combining sui repo binaries into this single image (similar to how we do for the |
## Description Describe the changes or additions included in this PR. ## Test Plan ``` » RUST_LOG=debug cargo r -- s i --path ../my-dumb-service Compiling suiop-cli v0.1.5 (/Users/jkjensen/mysten/sui/crates/suiop-cli) Finished dev [unoptimized + debuginfo] target(s) in 2.62s Running `/Users/jkjensen/mysten/sui/target/debug/suiop s i --path ../my-dumb-service` 2024-01-23T20:39:35.910330Z INFO suioplib::cli::service::init: creating rust service in ../my-dumb-service 2024-01-23T20:39:35.910729Z DEBUG suioplib::cli::service::init: sui service: true ``` ``` diff --git a/Cargo.toml b/Cargo.toml index afa17929a1..b194896523 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -187,7 +187,7 @@ members = [ "sui-execution/v0/sui-verifier", "sui-execution/v1/sui-adapter", "sui-execution/v1/sui-move-natives", - "sui-execution/v1/sui-verifier", + "sui-execution/v1/sui-verifier", "my-dumb-service", ] ``` --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
Description
The sui-services docker image exists to support non-node-operator services. Put new services generated in the sui repo into it to bundle them with other services.
Test Plan
If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)
Release notes