[move] Add fine-grained calls to stacker across the compiler (#16582)

## Description 

This replaces the previous stacker fix with an annotation proc macro
that bumps the stack any time it's at risk of running out of room.

## Test Plan 

Everything still works as expected, plus windows tests (TBD).

---
If your changes are not user-facing and do not break anything, you can
skip the following section. Otherwise, please briefly describe what has
changed under the Release Notes section.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes

external-crates/move/crates/move-compiler/Cargo.toml

@@ -33,6 +33,7 @@ move-ir-to-bytecode.workspace = true
 move-borrow-graph.workspace = true
 move-bytecode-source-map.workspace = true
 move-command-line-common.workspace = true
+move-proc-macros.workspace = true
 
 [dev-dependencies]
 move-stdlib.workspace = true

external-crates/move/crates/move-compiler/src/cfgir/borrows/mod.rs

@@ -15,6 +15,7 @@ use crate::{
     parser::ast::BinOp_,
     shared::{unique_map::UniqueMap, CompilationEnv},
 };
+use move_proc_macros::growing_stack;
 use state::{Value, *};
 use std::{cell::RefCell, collections::BTreeMap, rc::Rc};
 
@@ -150,6 +151,7 @@ fn unused_mut_borrows(
 // Command
 //**************************************************************************************************
 
+#[growing_stack]
 fn command(context: &mut Context, sp!(loc, cmd_): &Command) {
     use Command_ as C;
     match cmd_ {
@@ -221,6 +223,7 @@ fn lvalue(context: &mut Context, sp!(loc, l_): &LValue, value: Value) {
     }
 }
 
+#[growing_stack]
 fn exp(context: &mut Context, parent_e: &Exp) -> Values {
     use UnannotatedExp_ as E;
     let eloc = &parent_e.exp.loc;

external-crates/move/crates/move-compiler/src/cfgir/liveness/mod.rs

@@ -16,6 +16,7 @@ use crate::{
     shared::{unique_map::UniqueMap, CompilationEnv},
 };
 use move_ir_types::location::*;
+use move_proc_macros::growing_stack;
 use state::*;
 use std::collections::{BTreeMap, BTreeSet, VecDeque};
 
@@ -80,6 +81,7 @@ fn analyze(
     (final_invariants, liveness.states)
 }
 
+#[growing_stack]
 fn command(state: &mut LivenessState, sp!(_, cmd_): &Command) {
     use Command_ as C;
     match cmd_ {
@@ -116,6 +118,7 @@ fn lvalue(state: &mut LivenessState, sp!(_, l_): &LValue) {
     }
 }
 
+#[growing_stack]
 fn exp(state: &mut LivenessState, parent_e: &Exp) {
     use UnannotatedExp_ as E;
     match &parent_e.exp.value {
@@ -176,6 +179,8 @@ pub fn last_usage(
 }
 
 mod last_usage {
+    use move_proc_macros::growing_stack;
+
     use crate::{
         cfgir::liveness::state::LivenessState,
         diag,
@@ -238,6 +243,7 @@ mod last_usage {
         }
     }
 
+    #[growing_stack]
     fn command(context: &mut Context, sp!(_, cmd_): &mut Command) {
         use Command_ as C;
         match cmd_ {
@@ -296,6 +302,7 @@ mod last_usage {
         }
     }
 
+    #[growing_stack]
     fn exp(context: &mut Context, parent_e: &mut Exp) {
         use UnannotatedExp_ as E;
         match &mut parent_e.exp.value {

external-crates/move/crates/move-compiler/src/cfgir/locals/mod.rs

@@ -19,6 +19,7 @@ use crate::{
     shared::{unique_map::UniqueMap, *},
 };
 use move_ir_types::location::*;
+use move_proc_macros::growing_stack;
 use move_symbol_pool::Symbol;
 use state::*;
 use std::collections::BTreeMap;
@@ -207,6 +208,7 @@ fn unused_let_muts<T>(
 // Command
 //**************************************************************************************************
 
+#[growing_stack]
 fn command(context: &mut Context, sp!(loc, cmd_): &Command) {
     use Command_ as C;
     match cmd_ {
@@ -343,6 +345,7 @@ fn lvalue(context: &mut Context, case: AssignCase, sp!(loc, l_): &LValue) {
     }
 }
 
+#[growing_stack]
 fn exp(context: &mut Context, parent_e: &Exp) {
     use UnannotatedExp_ as E;
     let eloc = &parent_e.exp.loc;

external-crates/move/crates/move-compiler/src/cfgir/optimize/constant_fold.rs

@@ -14,6 +14,7 @@ use crate::{
     shared::unique_map::UniqueMap,
 };
 use move_ir_types::location::*;
+use move_proc_macros::growing_stack;
 use std::convert::TryFrom;
 
 /// returns true if anything changed
@@ -49,6 +50,7 @@ pub fn optimize(
 
 // Some(changed) to keep
 // None to remove the cmd
+#[growing_stack]
 fn optimize_cmd(
     consts: &UniqueMap<ConstantName, Value>,
     sp!(_, cmd_): &mut Command,
@@ -79,6 +81,7 @@ fn optimize_cmd(
     })
 }
 
+#[growing_stack]
 fn optimize_exp(consts: &UniqueMap<ConstantName, Value>, e: &mut Exp) -> bool {
     use UnannotatedExp_ as E;
     let optimize_exp = |e| optimize_exp(consts, e);

external-crates/move/crates/move-compiler/src/cfgir/optimize/eliminate_locals.rs

@@ -48,6 +48,8 @@ fn count(signature: &FunctionSignature, cfg: &MutForwardCFG) -> BTreeSet<Var> {
 }
 
 mod count {
+    use move_proc_macros::growing_stack;
+
     use crate::{
         hlir::ast::{FunctionSignature, *},
         parser::ast::{BinOp, UnaryOp},
@@ -109,6 +111,7 @@ mod count {
         }
     }
 
+    #[growing_stack]
     pub fn command(context: &mut Context, sp!(_, cmd_): &Command) {
         use Command_ as C;
         match cmd_ {
@@ -146,6 +149,7 @@ mod count {
         }
     }
 
+    #[growing_stack]
     fn exp(context: &mut Context, parent_e: &Exp) {
         use UnannotatedExp_ as E;
         match &parent_e.exp.value {
@@ -252,6 +256,7 @@ fn eliminate(cfg: &mut MutForwardCFG, ssa_temps: BTreeSet<Var>) {
 mod eliminate {
     use crate::hlir::ast::{self as H, *};
     use move_ir_types::location::*;
+    use move_proc_macros::growing_stack;
     use std::collections::{BTreeMap, BTreeSet};
 
     pub struct Context {
@@ -272,6 +277,7 @@ mod eliminate {
         }
     }
 
+    #[growing_stack]
     pub fn command(context: &mut Context, sp!(_, cmd_): &mut Command) {
         use Command_ as C;
         match cmd_ {
@@ -338,6 +344,7 @@ mod eliminate {
         }
     }
 
+    #[growing_stack]
     fn exp(context: &mut Context, parent_e: &mut Exp) {
         use UnannotatedExp_ as E;
         match &mut parent_e.exp.value {

external-crates/move/crates/move-compiler/src/cfgir/optimize/forwarding_jumps.rs

@@ -26,6 +26,8 @@
 // Label 2:
 //     ...
 
+use move_proc_macros::growing_stack;
+
 use crate::{
     cfgir::{
         ast::remap_labels,
@@ -123,6 +125,7 @@ fn optimize_forwarding_jumps(
     changed
 }
 
+#[growing_stack]
 fn optimize_cmd(sp!(_, cmd_): &mut Command, final_jumps: &BTreeMap<Label, Label>) -> bool {
     use Command_ as C;
     match cmd_ {

external-crates/move/crates/move-compiler/src/cfgir/optimize/inline_blocks.rs

@@ -2,6 +2,8 @@
 // Copyright (c) The Move Contributors
 // SPDX-License-Identifier: Apache-2.0
 
+use move_proc_macros::growing_stack;
+
 use crate::{
     cfgir::{
         ast::remap_labels,
@@ -34,6 +36,7 @@ fn optimize_(start: Label, blocks: &mut BasicBlocks) -> bool {
     inline_single_target_blocks(&single_target_labels, start, blocks)
 }
 
+#[growing_stack]
 fn find_single_target_labels(start: Label, blocks: &BasicBlocks) -> BTreeSet<Label> {
     use Command_ as C;
     let mut counts = BTreeMap::new();

external-crates/move/crates/move-compiler/src/cfgir/optimize/mod.rs

@@ -7,6 +7,7 @@ mod forwarding_jumps;
 mod inline_blocks;
 mod simplify_jumps;
 
+use move_proc_macros::growing_stack;
 use move_symbol_pool::Symbol;
 
 use crate::{
@@ -40,6 +41,7 @@ const MOVE_2024_OPTIMIZATIONS: &[Optimization] = &[
     inline_blocks::optimize,
 ];
 
+#[growing_stack]
 pub fn optimize(
     env: &mut CompilationEnv,
     package: Option<Symbol>,

external-crates/move/crates/move-compiler/src/cfgir/optimize/simplify_jumps.rs

@@ -2,6 +2,8 @@
 // Copyright (c) The Move Contributors
 // SPDX-License-Identifier: Apache-2.0
 
+use move_proc_macros::growing_stack;
+
 use crate::{
     cfgir::cfg::MutForwardCFG,
     expansion::ast::Mutability,
@@ -31,6 +33,7 @@ pub fn optimize(
     changed
 }
 
+#[growing_stack]
 fn optimize_cmd(sp!(_, cmd_): &mut Command) -> bool {
     use Command_ as C;
     use UnannotatedExp_ as E;

external-crates/move/crates/move-compiler/src/cfgir/translate.rs

@@ -19,6 +19,7 @@ use crate::{
 use cfgir::ast::LoopInfo;
 use move_core_types::{account_address::AccountAddress as MoveAddress, runtime_value::MoveValue};
 use move_ir_types::location::*;
+use move_proc_macros::growing_stack;
 use move_symbol_pool::Symbol;
 use petgraph::{
     algo::{kosaraju_scc as petgraph_scc, toposort as petgraph_toposort},
@@ -664,6 +665,7 @@ fn function_body(
 
 type BlockList = Vec<(Label, BasicBlock)>;
 
+#[growing_stack]
 fn block(context: &mut Context, stmts: H::Block) -> BlockList {
     let (start_block, blocks) = block_(context, stmts);
     [(context.new_label(), start_block)]
@@ -672,6 +674,7 @@ fn block(context: &mut Context, stmts: H::Block) -> BlockList {
         .collect()
 }
 
+#[growing_stack]
 fn block_(context: &mut Context, stmts: H::Block) -> (BasicBlock, BlockList) {
     let mut current_block: BasicBlock = VecDeque::new();
     let mut blocks = Vec::new();
@@ -736,6 +739,7 @@ fn finalize_blocks(
     (out_label, out_blocks, block_info)
 }
 
+#[growing_stack]
 fn statement(
     context: &mut Context,
     sp!(sloc, stmt): H::Statement,

external-crates/move/crates/move-compiler/src/cfgir/visitor.rs

@@ -19,6 +19,7 @@ use crate::{
     shared::CompilationEnv,
 };
 use move_ir_types::location::*;
+use move_proc_macros::growing_stack;
 
 pub type AbsIntVisitorObj = Box<dyn AbstractInterpreterVisitor>;
 
@@ -336,6 +337,7 @@ pub trait SimpleAbsInt: Sized {
     ) -> Option<Vec<<Self::State as SimpleDomain>::Value>> {
         None
     }
+    #[growing_stack]
     fn exp(
         &self,
         context: &mut Self::ExecutionContext,

external-crates/move/crates/move-compiler/src/command_line/compiler.rs

@@ -26,6 +26,7 @@ use move_command_line_common::files::{
     find_filenames_vfs, MOVE_COMPILED_EXTENSION, MOVE_EXTENSION, SOURCE_MAP_EXTENSION,
 };
 use move_core_types::language_storage::ModuleId as CompiledModuleId;
+use move_proc_macros::growing_stack;
 use move_symbol_pool::Symbol;
 use pathdiff::diff_paths;
 use std::{
@@ -341,7 +342,7 @@ impl<'a> Compiler<'a> {
         }
 
         let (mut source_text, pprog, comments) =
-            with_large_stack!(parse_program(&mut compilation_env, maps, targets, deps,))?;
+            parse_program(&mut compilation_env, maps, targets, deps)?;
 
         source_text
             .iter_mut()
@@ -923,6 +924,7 @@ fn run(
     until: Pass,
     result_check: impl FnMut(&PassResult, &CompilationEnv),
 ) -> Result<PassResult, (Pass, Diagnostics)> {
+    #[growing_stack]
     fn rec(
         compilation_env: &mut CompilationEnv,
         pre_compiled_lib: Option<&FullyCompiledProgram>,
@@ -1025,13 +1027,7 @@ fn run(
             PassResult::Compilation(_, _) => unreachable!("ICE Pass::Compilation is >= all passes"),
         }
     }
-    with_large_stack!(rec(
-        compilation_env,
-        pre_compiled_lib,
-        cur,
-        until,
-        result_check
-    ))
+    rec(compilation_env, pre_compiled_lib, cur, until, result_check)
 }
 
 //**************************************************************************************************

external-crates/move/crates/move-compiler/src/expansion/translate.rs

@@ -26,6 +26,7 @@ use crate::{
 use move_command_line_common::parser::{parse_u16, parse_u256, parse_u32};
 use move_core_types::account_address::AccountAddress;
 use move_ir_types::location::*;
+use move_proc_macros::growing_stack;
 use move_symbol_pool::Symbol;
 use std::{
     collections::{BTreeMap, BTreeSet, VecDeque},
@@ -2804,6 +2805,7 @@ fn optional_types(context: &mut Context, pts_opt: Option<Vec<P::Type>>) -> Optio
 // Expressions
 //**************************************************************************************************
 
+#[growing_stack]
 fn sequence(context: &mut Context, loc: Loc, seq: P::Sequence) -> E::Sequence {
     let (puses, pitems, maybe_last_semicolon_loc, pfinal_item) = seq;
 
@@ -2831,6 +2833,7 @@ fn sequence(context: &mut Context, loc: Loc, seq: P::Sequence) -> E::Sequence {
     (use_funs, items)
 }
 
+#[growing_stack]
 fn sequence_item(context: &mut Context, sp!(loc, pitem_): P::SequenceItem) -> E::SequenceItem {
     use E::SequenceItem_ as ES;
     use P::SequenceItem_ as PS;
@@ -2873,6 +2876,7 @@ fn exps(context: &mut Context, pes: Vec<P::Exp>) -> Vec<E::Exp> {
         .collect()
 }
 
+#[growing_stack]
 fn exp(context: &mut Context, pe: Box<P::Exp>) -> Box<E::Exp> {
     use E::Exp_ as EE;
     use P::Exp_ as PE;
@@ -3197,6 +3201,7 @@ fn move_or_copy_path_(context: &mut Context, case: PathCase, pe: Box<P::Exp>) ->
     })
 }
 
+#[growing_stack]
 fn exp_dotted(context: &mut Context, pdotted: Box<P::Exp>) -> Option<Box<E::ExpDotted>> {
     use E::ExpDotted_ as EE;
     use P::Exp_ as PE;