Skip to content

Commit

Permalink
[CheckpointExecutor] Remove unneccesary asyncs (#18110)
Browse files Browse the repository at this point in the history
## Description 

As in title

## Test plan 

It compiles

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
  • Loading branch information
williampsmith authored Jun 8, 2024
1 parent ef9e024 commit 3183e10
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions crates/sui-core/src/checkpoints/checkpoint_executor/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ impl CheckpointExecutor {
.set(is_inconsistent_state as i64);
}

async fn bump_highest_executed_checkpoint(&self, checkpoint: &VerifiedCheckpoint) {
fn bump_highest_executed_checkpoint(&self, checkpoint: &VerifiedCheckpoint) {
// Ensure that we are not skipping checkpoints at any point
let seq = *checkpoint.sequence_number();
debug!("Bumping highest_executed_checkpoint watermark to {seq:?}");
Expand Down Expand Up @@ -434,7 +434,7 @@ impl CheckpointExecutor {
.accumulate_running_root(epoch_store, checkpoint.sequence_number, checkpoint_acc)
.await
.expect("Failed to accumulate running root");
self.bump_highest_executed_checkpoint(checkpoint).await;
self.bump_highest_executed_checkpoint(checkpoint);
}
}

Expand Down Expand Up @@ -689,7 +689,7 @@ impl CheckpointExecutor {
.await
.expect("Accumulating epoch cannot fail");

self.bump_highest_executed_checkpoint(checkpoint).await;
self.bump_highest_executed_checkpoint(checkpoint);

return true;
}
Expand Down

0 comments on commit 3183e10

Please sign in to comment.