Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBO-18 finetuning #319

Closed
wants to merge 10 commits into from
Closed

UBO-18 finetuning #319

wants to merge 10 commits into from

Conversation

kkrebs
Copy link
Contributor

@kkrebs kkrebs commented Sep 5, 2023

No description provided.

Possommi and others added 10 commits August 24, 2023 14:29
* UBO-96 Added button to unlink user account from ORCID

UBO-96 Added i18n key 'orcid.integration.unlink'

UBO-96 Added DozBibUserServlet

UBO-96 Code format web-fragment.xml

UBO-96 Placed orcid button inside <p>-element

UBO-96 Added Testing Servlet

UBO-96 Store updated UserAttributes

UBO-96 Check for guest user

* UBO-96 Added dependency to org.mycore:mycore-orcid2

* UBO-96 Removed dependency to org.mycore:mycore-orcid
Commented code to make ubo-common compile

* UBO-96 Set redirect url to $WebApplicationBaseURL/orcid

* UBO-96 Added ORCIDTools.js
UBO-96 Renamed mycore-orcid properties to their equivalent mycore-orcid2 properties

* UBO-96 Updated check for presence of orcid token

* UBO-96 Updated DozBibUserServlet to use mycore-orcid2 api

* UBO-96 Added method 'revoke' to ORCIDTools.js

* UBO-96 Added ubo-dialog.xsl

* UBO-96 Show confirm dialog when user trys to revoke orcid connection

* UBO-96 Read number of publications for user from orcid
UBO-96 Added DozBibORCIDUtils (WIP)

* UBO-96 Test for orcid_credential attribute rather than orcid_id

* UBO-96 Added public static boolean weAreTrustedParty() to DozBibORCIDUtils

* UBO-96 Renamed DozBibUserServlet to DozBibORCIDUserServlet and moved class to package /org/mycore/ubo/orcid/

* UBO-96 Migrated orcid list import

* UBO-96 Renamed property MCR.ORCID.LinkURL to MCR.ORCID2.LinkURL in mods-display.xsl

* UBO-96 Migrated mycore2orcid.js to mycore-orcid2

* UBO-96 Added simple notification dialog to ubo-dialog.xsl

* UBO-96 Fixed grammar

* UBO-96 Do not use slang as button label

* UBO-96 Changed upload to orcid button type

* UBO-96 Fixed orcid indicator title/tooltip

* UBO-96 Fixed link to orcid in user profile

* UBO-96 Reflect changes from /rsc to /api in mycore-orcic2 (WIP)

* UBO-96 Added orcid2 properties

* UBO-96 Deprecated ORCIDTools.js

* UBO-96 Use JWT and include /modules/orcid2/js/orcid-auth.js from mycore-orcid2

* UBO-96 Removed ORCIDTools.js

* UBO-96 Removed method loadScript()

* UBO-96 Reflect recent changes in mycore-orcid2

* UBO-96 Use POST http method for pushing a publication to ORCID

* UBO-96 Changed position of MCRORCIDWorkEventHandler

* UBO-96 Endpoint is splitted into update and create

* UBO-96 Allow user to activate automatic update of ORCID® profile

* UBO-96 Reflect sync status in orcid status headline

* UBO-96 Renamed user attribute to orcid_update_profile (name might change later)

* UBO-96 Changed some i18n values in messages_en.properties

* UBO-96 Fixed NPE and updated javadoc

* UBO-96 Remove TODO in MCRUserMatcherUtils

* UBO-96 Delete user attribute 'orcid_update_profile' when orcid auth is removed

* UBO-96 Added action parameter to DozBibORCIDUserServlet

* UBO-96 Do not die on invalid token

* UBO-96 Set propert MCR.ORCID2.WorkEventHandler.UpdateOnlyExisting = true

* UBO-96 Format

* UBO-96 Disable upload to orcid button once it was clicked

* UBO-96 Test for property MCR.ORCID2.Client.V3.APIMode

* UBO-96 Added include in html-layout.xsl to user-orcid.xsl

* UBO-96 public static String getFirstOrcidByCurrentUser() to DozBibORCIDUtils to enable linking to orcid

* UBO-96 Updated import of MCRORCIDWorkUtils to org.mycore.orcid2.v3.work.MCRORCIDWorkUtils

* UBO-96 Updated MCR.EventHandler.MCRObject.018A.Class

* UBO-96 Updated properties reflecting latest changes in mycore-orcid2

* UBO-96 Disabled update by user

* UBO-96 Show id of publication when logging to js console

* UBO-96 adopt to new orcid2 version

* UBO-96 update ORCIDWorkEventHandler to new version

* UBO-96 updated create-work path

* Improve orcid unlinking and allow to change user settings

* UBO-96 Added i18n orcid.integration.list to messages_en.properties

* UBO-96 Added i18n orcid.integration.settings.title to messages_en.properties

* UBO-96 Added i18n orcid.integration.settings.createFirstWork, orcid.integration.settings.alwaysUpdateWork, orcid.integration.settings.createDuplicateWork, orcid.integration.settings.recreateDeletedWork to messages_en.properties

* UBO-96 reformat message properties for better diff

* UBO-96 fix translation bug

* UBO-96 set editable user attributes, to prevent editing of orcid token

* UBO-96 Added public static int getNumWorks(String orcid) to DozBibORCIDUtils.java

* UBO-96 Added javadoc and altered public static int getNumWorks() (returns now the total of publications based on all connected orcids)

* UBO-96 Display orcid id in summary line

* UBO-96 Added public static boolean isConnected(String orcid) to DozBibORCIDUtils

* UBO-96 Removed public static boolean hasSyncEnabled() from DozBibORCIDUtils since it is obsolete

* UBO-96 Fixed javadoc in DozBibORCIDUserServlet

* UBO-96 update information text

---------

Co-authored-by: Kathleen Neumann <[email protected]>
Co-authored-by: Sebastian Hofmann <[email protected]>
  - KDSF fields for peer reviewed, access rights and typeOfResource
  - optimize validation and mandatory style
  - make subtitle repeatable
* UBO-18 unify name identifier handling
* UBO-18 use name identifier classification and code refacturing
* UBO-18 do not display identifier marked with x-display=false
* UBO-18 set color of connected author icon to primary color
@kkrebs kkrebs closed this Sep 5, 2023
@kkrebs kkrebs deleted the issues/UBO-18_finetuning branch September 5, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants