Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape key on the main menu wont exit the app #621

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

Mystic-Slice
Copy link
Contributor

Description

I agree with @Cervator on the 2nd point in issue #616 (about the Esc key closing the app itself). It seems very abrupt. I do not think the Esc key should close the app. But if it is needed, then there should be at least a confirmation dialog before quitting the app.

Testing

Open the app and try pressing the Esc key. The app won't close.

Pre Pull Request Checklist:

  • Code has been scanned with SonarLint
  • There are no errors present in the project
  • Code has been formatted and indented
  • Methods have appropriate Javadoc (How to write Javadoc)

Copy link
Member

@Cervator Cervator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay less abrupt :-)

@Cervator Cervator merged commit eb471c7 into MovingBlocks:develop Oct 4, 2021
@Cervator Cervator added this to the v2.1.0 milestone Oct 4, 2021
@Cervator Cervator mentioned this pull request Oct 16, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants