Send notification when video play fails #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reselve comments on PR
|
Sorry in the middle of changes so this will need to be rebased again. Suggest raising a PR in andxpanic/plugin.video.youtube instead to avoid the hassle |
MoojMidge
force-pushed
the
master
branch
4 times, most recently
from
3844c3f to
3b84bf9
Compare
|
I'm going to close this as there are too many changes being made at the moment. I'll add the notification at a different location as part of a seperate commit to this repo, should also address the issue you raised about the history navigation. |
|
Can you test https://github.com/MoojMidge/plugin.video.youtube/archive/refs/heads/master.zip and see whether the failed notification works and also that the history modification doesn't occur when using another plugin? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messed up my history on my branch so closed the previous PR. sorry. Rebased and squashed the requested changes.
Comment from previous:
But looking at it from a higher level, if the intent is to close a dialog and re-open it once playback has completed, wouldn't a better way of doing this be to only close the dialog if the PLAYBACK_STARTED notification is received?
Looked at PLAYBACK_STARTED and ti seems to work, except it looked like a problem if Inputstream fails for some reason. But regardless I still need to have a way to know that Youtube plugin has "given up" or I end up with things like "One or more streams failed to play" confirm dialog getting buried under my restored dialogs, and user never gets to click "OK" on it which causes problems downstream.
Is there a preferred fork/branch you want PRs against?