Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Four More New Custom AI Law Modules for Monkestation, and a Grammar fix #738

Closed
wants to merge 8 commits into from

Conversation

WonderPsycho
Copy link
Contributor

@WonderPsycho WonderPsycho commented Dec 17, 2023

Just a small update fixing a grammar error in one lawset module and adding 4 new AI Lawset Modules,

About The Pull Request

4 new AI modules for AI Upload and one for Syndie Ops, in their AI Law module lootdrop, and one grammar error fix

Need I say more? that's all folks

Why It's Good For The Game

GRAMMAR ERROR FIXED, MORE AI LAW MODULES A SLIGHT BIT

Changelog

🆑
add: Added 4 new AI Law Modules to AI Upload Lootdrop spawners, one of them also spawnable in the Syndicate Operative AI Law Module Lootdrop Spawner, and one grammar error fix, and that's it
/:cl:

@DexeeXI
Copy link
Contributor

DexeeXI commented Dec 17, 2023

Looking this over, the positive oxylaw is something that could be a useful tool for AIs that are completely apathetic to the state of atmos around the station.

I'm not 100% sold on the other law boards.

The custom 0th law could be a funny but could also be a trouble on its own, so it is difficult to say what its purposes would be or methods of getting it. Because it seems to be tied to syndie boards, its probably on that random spawner from what I can tell.

The cat law is fuckin hilarious but I do worry a tad bit about its self-antag potential of a player role that is basically an antagonist thats chained by its laws. Granted, there are far worse things like Nutsimov. There could be some sort of a tm on this, but there's a gut feelin' I got that it ain't gonna be the best received.

The small typo fix would be more than fine though.

@WonderPsycho
Copy link
Contributor Author

thanks for your thoughts, as for the zeroth law thing, wait really the freeform zeroth law module is not on the spawners? I think I may have forgot to save the edit of adding said module to the neutral ai module lootdrop spawner so that the module may spawn in the neutral module case secured in there, knowing for a fact, that said module is dangerous depending on what zeroth law whoever has a hold of it will write on it...

but yeah if it's not in the spawners I'll go and fix that, also I understand the worries from the Cat Madness Ai Module, atleast the module is in the dangerous ai module lootdrop and syndie ai module lootdrop spawners so in the AI Upload if someone where to try and break in, said module will be secured,

and hopefully said self-antagger is dealt with by the turrets and or the hos and command, while also only having the module be accessible to Nukie Operatives for if they want to use it to fuck with the AI's laws to have the AI being a distraction for the crew while the Nukies get into setting the nuke or other things

@WonderPsycho
Copy link
Contributor Author

wait no I misread sorry, but yeah it's on the neutral AI module spawner that spawns said modules in the blue neutral AI module case to keep them secure, from what I know, Zeroth law AI modules spawn rarer then lawset modules and other modules on lootdrop spawners, thought for a sec that I may have not saved properly on a PR I was working on

@WonderPsycho
Copy link
Contributor Author

after some thinking I decided it would be better to try and do some more balancing changes to this PR when it comes to the new AI modules it introduces, one idea being restricting "Cat Madness" to the syndie AI Module lootdrop spawner to prevent graytiders from getting access to it to grief the AI,

but will get started in adding these changes tomorrow (or today, but when I wake up since it's super early in the morning on my end rn (1 am))

realized, I did a fuck up in the lootdrop spawners, and that they need a comma at the end everytime in order for the last one to be lootdrop spawned.., should've realized this earlier but yeah
@WonderPsycho
Copy link
Contributor Author

WonderPsycho commented Dec 31, 2023

realized I fucked up the lootdrop spawns when I first made this PR, which is why I didn't get the see the freeformzeroth module in my testing in the first place, it was because I was missing some commas, now awaiting for borbop (or anyone) to give this a check, let me know what changes I should probably make to it or remove, and yeah

@dwasint dwasint closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants