Fixes space ruin generation #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok turns out this isn't working for some reason I hate coding |
added 5 commits
May 7, 2023 14:35
…SPAGHETTITHE SPAGHETTITHE SPAGHETTITHE SPAGHETTITHE SPAGHETTITHE SPAGHETTITHE SPAGHETTITHE SPAGHETTITHE SPAGHETTITHE SPAGHETTI
|
continuing to work on this, tougher to crack than I first presumed |
|
Request a re-open when this PR is ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
I have a friend who knows a lot about the inner machinations of the game, I invited him to hang out on Monkestation and we decided to pop out to space for fun.
Turns out he's figured out that we're generating 10x less space ruins than we should be, there probably was a issue in the ruin distribution formula. I've fixed it by basically copying TGstation pull #74841
Why It's Good For The Game
Bug fixes are good, and space exploration was weirdly anemic so we'd basically only get an extremely low number of ruins.
Furthermore it will cut down on spaghetti code, preventing unnecessary generation of empty z-levels, and allow for future mappers to customize how many space z-levels should be generated.
Changelog
🆑
fix: Space ruins are now spawning at their intended rate.
/:cl: