Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOVA PORT] Alternate AI Vox #4135

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

Noot-Toot
Copy link
Contributor

@Noot-Toot Noot-Toot commented Nov 7, 2024

About The Pull Request

This PR adds THREE new AI VOX packs to choose from for station AIs. The list is now the following:
Normal VOX: The regular youve always been hearing.
Half Life VOX
Black Mesa VOX
Black Mesa Military VOX (Modified so ALL AIs get to use it, not just malf.)

Also adds the Word String commands, they were in the module so i just said why not.

Alt.VOX.showcase.mp4

dw about the debug text i just forgor to recompile, also dont bother me about the ass recording it works, also dont worry about the faxables shit in here, thats merged and i forgor to make a new branch and im NOT doing this all over again.

Why It's Good For The Game

I think its cool
Allows AI players more choice in customization and expression, and it sounds cool.

Changelog

🆑 Tractor Mann (Original Code by Gandalf2k15, GoldenAlpharex, And others from NovaSector)
add: 3 New AI VOXes! Pick from Black Mesa/Black Mesa Military or Half Life VOX! or just keep using the normal one!
add: "Display Word String" AI Verb, to quickly print the pushed VOX words from Announcement Help into chat.
/:cl:

Add recieve_notifies_admins which lets centcom faxes be actually admin.
Add more exotic faxes, most of which entirely forego the original coders idea of "generally flat stuff" but its funny so it doesnt matter
changes the paper only message for NT faxes
Disables jamming.
minor spelling mistake, i am instantly eviscerated for my crimes.
adds in a few icons for the sent/recieved items, specifically the gun, handcuffs and peel. as you can tell i am no artist.
unfortunately, this let amogi players be faxed to centcom. which is REALLY bad. like SUUUPER bad.
fortunately, this now by technicality gives all the faxes i added icons because the only one without now no longer exists.
readded the power to fax pets/amogi (amogi part unintentional its just coded that way) BUT this time, you cant fax to centcom! trying to send a fax to centcom will fail. Also adds a admin subtype to faxes that come with hacking already AND notifies admins when it recieves letters
because it was voted for on a poll on discord, sure it only has 2 votes and has 23 hours left, but i can just change it back if need be.
i immediately miss the button and am shot on the spot (forgot a ,)
tested and works, C4 on regular paper plants it, C4 on rolling paper still becomes a blunt but thats ok.
guess who went back on "should be everything in my pr done" again!
the issues brought up were already solved, but i just want this PR through
I gotta get these PRs outta my house by sunday, im having a potluck! do you have any idea whatll happen if they see all these PRs in my house? HOW EMBARRASING!
there was 2 breadslices in the list. whoopsie!
Still needs work done, the announcement help is broken and doesnt actually preview the words, but it DOES work for display strings and switching between avaliable words per vox. so its just that 1 bit thats keeping this from being PRable.
it used null as ai_turf, so it could never find the AI on that turf to find their VOX setting.  but the vox announcement grabbed the AIs turf, so that worked perfectly fine. now it get_turf's the AI, so itll give the AIs turf to get evaluated to find the AI on that turf, making this a entire waste of everyones time.
@destrucktoid
Copy link

Not going to lie, personally i prefer the military voice to be Malf only since most of the things on it are things only a malf AI would use anyway and it adds to the coolness for malf AI but making it available to all AI is fine.

@Noot-Toot
Copy link
Contributor Author

Not going to lie, personally i prefer the military voice to be Malf only since most of the things on it are things only a malf AI would use anyway and it adds to the coolness for malf AI but making it available to all AI is fine.

I added it to all AIs with the thinking that malf AIs are rare, and you would rarely want to meta-expose yourself as malfunctioning with the military vox, and subverted AIs could also benefit from it

@destrucktoid
Copy link

Not going to lie, personally i prefer the military voice to be Malf only since most of the things on it are things only a malf AI would use anyway and it adds to the coolness for malf AI but making it available to all AI is fine.

I added it to all AIs with the thinking that malf AIs are rare, and you would rarely want to meta-expose yourself as malfunctioning with the military vox, and subverted AIs could also benefit from it

Which is fair enough!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants