Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Three player rendering fixes #4068

Merged
merged 13 commits into from
Nov 6, 2024
Merged

Conversation

Sorenon
Copy link
Contributor

@Sorenon Sorenon commented Nov 2, 2024

About The Pull Request

Why It's Good For The Game

  • Dwarfish people deserve to be able to see
  • Giant people deserve to be able to dance
  • Florans deserve to look pretty

Changelog

🆑
fix: fixed dwarfish people not having eyes
fix: fixed giant people shrinking when they break-dance
fix: fixed floran / pod people hair being drawn bellow clothing
/:cl:

@Absolucy
Copy link
Collaborator

Absolucy commented Nov 3, 2024

causing notable visual bugs with tall players (left), and possibly hair rendering (right)

2024-11-03 (1730672090) ~ dreamseeker

@Sorenon
Copy link
Contributor Author

Sorenon commented Nov 4, 2024

causing notable visual bugs with tall players (left), and possibly hair rendering (right)

2024-11-03 (1730672090) ~ dreamseeker

It looks like the issue on the left is due to a TG bug tgstation/tgstation#77440 which might be the reason human_face.dmi was resized to 32x48 in the first place. Definitely fixable it just might take a bit longer than expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants