-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Day/Night Cycle and Particle Weathers #249
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linters gonna fail for a bit until i add in a anti linter check as particles can support chaining generators documentation says so but compiler cries still. It does work as shown in game. |
… unlikely to ever process
forgor to un-tm this but its been tested a fair bit and ready for merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
from: Mojave-Sun/mojave-sun-13#1307
Adds a new ZTRAIT Daycycle which allows z-levels to have a day/night system tied to station time.
Also adds the framework for particle based weathers which look nicer than current weathers.
Features of this include, weather z-level propagation, you can poke holes in the ceiling and it falls down,
Weather based effects, weather looping sounds, basically all of the standard weather features and than some.
Why It's Good For The Game
We need Daycycle for monkedome, and the particle based weather comes with the package from mojave
Changelog
🆑 BlackCrystalic, Koshenko
add: day/night cycle that changes brightness and color based on station time to icebox and oshan
add: framework for particle weathers, currently un-used in maps
/:cl: