Fixes exploitable memory leak regarding Rod of Asclepius and Telepathy #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also forgot to mention, the way I tested if there actually was a memory leak was by waiting 5 minutes and seeing if the CPU changed notably (it did not), then waiting 5 minutes after doing the bug. My CPU usage according to MC was up nearly 15% in 5 - 10 minutes. This definitely causes some lag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes an exploitable bug that causes increasing amounts of lag regarding the Rod of Asclepius and Telepathy. Prevented by checking that the owner is a carbon.
The reason this causes lag is likely due to growing arms to "regain" the rod of asclepius, which just continues to grow and grow. Eventually, this even turns your sprite into an error.
Closes #1519
Why It's Good For The Game
Memory leaks / bugs that cause lag - and those exploitable by griefers, especially, bad.
Changelog
🆑
fix: Rod of Asclepius can no longer be used with telepathy. The geneticist responsible has been forced to roll a boulder for the rest of time.
/:cl: