Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated to add a tag message for the initial git tag #185

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

ethanholz
Copy link
Contributor

@ethanholz ethanholz commented Mar 4, 2024

This PR fixes a bug wherein a message must be added if a user sets up git to GPG sign tags, doing so requires that every tag have a message. Without this, the installation will hang.

@Lnaden
Copy link
Collaborator

Lnaden commented Mar 4, 2024

Didn't realize that was an issue. Thanks for the PR!

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.44%. Comparing base (4c3ea62) to head (0552aee).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage   44.44%   44.44%           
=======================================
  Files          12       12           
  Lines          54       54           
=======================================
  Hits           24       24           
  Misses         30       30           
Flag Coverage Δ
unittests 44.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lnaden Lnaden merged commit b59ebfb into MolSSI:main Mar 4, 2024
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants