add local file storage target #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hirosassa
commented
Jun 13, 2021
| @@ -8,6 +8,10 @@ class Config(object): | |||
| # valid choice : "info", "warn", "error", "debug" | |||
| loglevel = "info" | |||
|
|
|||
| # Storage Target | |||
| # valid choice : "localfile", "firestore" | |||
There was a problem hiding this comment.
[need discussions] I'll add gcs target and/or the other object storages in another PR. How do you think about this idea?
hirosassa
commented
Jun 13, 2021
| from lib.table_desc import TableDesc | ||
|
|
||
|
|
||
| class Storage(metaclass=ABCMeta): |
There was a problem hiding this comment.
for extensibility of storage target, I implemented base class for storage
hirosassa
commented
Jun 13, 2021
| @@ -1,3 +1,6 @@ | |||
| #! /bin/bash | |||
| set -eu | |||
hirosassa
commented
Jun 13, 2021
| from lib.table_desc import TableDesc | ||
|
|
||
| TEST_DS = "test_bqdesc_buckuper" | ||
| TEST_DS = "test_bqdesc_backuper" |
hirosassa
commented
Jun 13, 2021
| class TestControllerBase(unittest.TestCase): | ||
| """Base class for controller test case. `self.storage` will be parameterized. | ||
| """ | ||
| __test__ = False # HACK: skip base class tests |
There was a problem hiding this comment.
To prevent running base class tests.
But this hack makes that we cannot use python -m unittest discover test because unittest discover command does not respect __test__ variables.
I'll add tox configurations to solve this problem later.
hirosassa
commented
Jun 13, 2021
|
|
||
| def setUp(self): | ||
| super().setUp() | ||
| self.storage = Firestore(config=config, logger=logger) |
hirosassa
changed the title
|
@TetsutaroWatanabe Plz review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR?
This PR adds storage target
LocalFileof local file instead ofFirestore.When you use
LocalFile, descriptions fetched from BigQuery will be stored in local directory as json files.In my use case, I need simpler solution than
Firestorefor some reasons.I want to discuss with reviewers whether this feature is preferable for this repo or not.
Thanks