Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for internet before attempting to download APK #2422

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Check for internet before attempting to download APK #2422

merged 4 commits into from
Sep 20, 2024

Conversation

ayushmanchhabra
Copy link
Contributor

@ayushmanchhabra ayushmanchhabra commented Sep 7, 2024

Describe the Pull Request

Check for internet before attempting to download an APK.

Checklist for PR

  • Run MobSF unit tests and lint tox -e lint,test
  • Tested Working on Linux, Mac, Windows, and Docker
  • Add unit test for any new Web API (Refer: StaticAnalyzer/tests.py)
  • Make sure tests are passing on your PR MobSF tests

Additional Comments (if any)

DESCRIBE HERE

Fixes: #2405

Copy link

721868

@ayushmanchhabra
Copy link
Contributor Author

/cc @juwop @ajinabraham

@ajinabraham
Copy link
Member

Thanks for the PR. I will take a look at this the earlier I can.

mobsf/MobSF/views/home.py Outdated Show resolved Hide resolved
Copy link
Member

@ajinabraham ajinabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajinabraham ajinabraham merged commit f6193dc into MobSF:master Sep 20, 2024
11 checks passed
yiwan330445 added a commit to yiwan330445/Mobile-Security-Framework-MobSF that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for Internet Availability Before Getting App Details form PlayStore
3 participants