Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof of concept opt-in navigation modification (use KMNavigationController) #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nikans
Copy link

@nikans nikans commented Apr 19, 2019

Because sometimes in complex VCs' hierarchies there happen to be bugs, and because giving a choice is generally considered a good practice (especially with such a crucial system component as navigation controller), I propose to create an opt-in version of this beautiful library.
My proposal is basically a hack (plus the last time I've been using obj-c was 4 years ago), but you can notice that there is a new KMNavigationController class, and modifications are applied only if this UINavigationController subclass is being used.
THE PROPOSED CODE REQUIRES HEAVY REFACTORING. Sorry for that, needed it fast.
Thank you for your consideration.
Swizzle responsibly! :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant