fix: invalid web service manifest generation #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pihole-web service is now valid when both serviceWeb.http and serviceWeb.https are disabled. Signed-off-by: JP Flouret <[email protected]>
|
Thank you very much! LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pihole-webservice is now valid when bothserviceWeb.httpandserviceWeb.httpsare disabled. Without this change, setting both of these to false will result in an invalid service manifest with an emptyspec.portsvalue.Description of the change
This change prevents the creation of the web service manifest if both
serviceWeb.http.enabledandserviceWeb.https.enabledarefalse. Setting either of these values to true (the default) will preserve existing behaviour.Benefits
Allows the user to not expose the pihole web service by disabling both http and https in the
serviceWebconfiguration option.Possible drawbacks
Applicable issues
Additional information
Checklist