Skip to content

[pull] master from magma:master #2888

[pull] master from magma:master

[pull] master from magma:master #2888

GitHub Actions / shellcheck failed Jul 28, 2024 in 0s

reviewdog [shellcheck] report

reported by reviewdog 🐶

Findings (36)

orc8r/tools/packer/scripts/third_party/chef_bento/cleanup_ubuntu.sh|22 col 15| Quote this to prevent word splitting.
orc8r/tools/packer/scripts/third_party/chef_bento/cleanup_ubuntu.sh|22 col 15| Use $(...) notation instead of legacy backticks ....
orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh|23 col 10| $/${} is unnecessary on arithmetic variables.
orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh|29 col 10| $/${} is unnecessary on arithmetic variables.
orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh|34 col 11| Use $(...) notation instead of legacy backticks ....
orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh|44 col 15| Use $(...) notation instead of legacy backticks ....
orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh|44 col 46| Double quote to prevent globbing and word splitting.
.devcontainer/post-create-commands.sh|12 col 51| Quote this to prevent word splitting.
lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh|58 col 7| Use -n instead of ! -z.
lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh|59 col 33| The surrounding quotes actually unquote this. Remove or escape them.
lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh|59 col 33| Double quote to prevent globbing and word splitting.
lte/gateway/docker/ghz/publish.sh|18 col 29| Word is of the form "A"B"C" (B indicated). Did you mean "ABC" or "A"B"C"?
lte/gateway/deploy/roles/agw_docker/files/agw_upgrade.sh|16 col 8| Not following: /var/opt/magma/docker/.env: openBinaryFile: does not exist (No such file or directory)
lte/gateway/deploy/roles/agw_docker/files/agw_upgrade.sh|23 col 22| Double quote to prevent globbing and word splitting.
lte/gateway/deploy/roles/magma_test/files/update_package.sh|45 col 18| Double quote to prevent globbing and word splitting.
third_party/build/bin/bcc_build.sh|17 col 8| Not following: ./../lib/util.sh: openBinaryFile: does not exist (No such file or directory)
third_party/build/bin/bcc_build.sh|22 col 1| VERSION appears unused. Verify use (or export if used externally).
third_party/build/bin/aioh2_build.sh|18 col 8| Not following: ./../lib/util.sh: openBinaryFile: does not exist (No such file or directory)
third_party/build/bin/aioh2_build.sh|37 col 8| Not following: env/bin/activate: openBinaryFile: does not exist (No such file or directory)
third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh|15 col 38| Quote this to prevent word splitting.
third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh|15 col 38| Use $(...) notation instead of legacy backticks ....
third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh|39 col 38| Quote this to prevent word splitting.
third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh|39 col 38| Use $(...) notation instead of legacy backticks ....
third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh|51 col 42| Quote this to prevent word splitting.
third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh|51 col 42| Use $(...) notation instead of legacy backticks ....
third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh|73 col 39| Quote this to prevent word splitting.
third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh|73 col 39| Use $(...) notation instead of legacy backticks ....
third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh|74 col 39| Quote this to prevent word splitting.
third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh|74 col 39| Use $(...) notation instead of legacy backticks ....
bazel/scripts/run_sudo_tests.sh|57 col 9| Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
bazel/scripts/run_sudo_tests.sh|133 col 7| Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
bazel/scripts/test_python_service_imports.sh|46 col 9| Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
nms/e2e_test_setup.sh|24 col 73| Consider using 'grep -c' instead of 'grep|wc -l'.
nms/e2e_test_setup.sh|25 col 10| Double quote to prevent globbing and word splitting.
nms/e2e_test_setup.sh|31 col 7| Use $((..)) instead of deprecated $[..]
nms/e2e_test_setup.sh|31 col 9| $/${} is unnecessary on arithmetic variables.

Filtered Findings (411)

cn/deploy/scripts/fluentd_prerequisites.sh|16 col 1| PASSWD appears unused. Verify use (or export if used externally).
cn/deploy/scripts/fluentd_prerequisites.sh|21 col 77| Double quote to prevent globbing and word splitting.
cn/deploy/scripts/fluentd_prerequisites.sh|22 col 262| Double quote to prevent globbing and word splitting.
cn/deploy/scripts/fluentd_prerequisites.sh|24 col 2| Consider using { cmd1; cmd2; } >> file instead of individual redirects.
cn/deploy/scripts/fluentd_prerequisites.sh|24 col 7| Expressions don't expand in single quotes, use double quotes for that.
cn/deploy/scripts/fluentd_prerequisites.sh|25 col 7| Expressions don't expand in single quotes, use double quotes for that.
cn/deploy/scripts/fluentd_prerequisites.sh|27 col 94| Double quote to prevent globbing and word splitting.
cn/deploy/scripts/fluentd_prerequisites.sh|29 col 9| ShellCheck can't follow non-constant source. Use a directive to specify location.
cn/deploy/scripts/fluentd_install.sh|16 col 1| PASSWD appears unused. Verify use (or export if used externally).
cn/deploy/scripts/fluentd_install.sh|27 col 95| Double quote to prevent globbing and word splitting.
cn/deploy/scripts/fluentd_install.sh|28 col 91| Double quote to prevent globbing and word splitting.
cn/deploy/scripts/fluentd_install.sh|124 col 92| Double quote to prevent globbing and word splitting.
cn/deploy/scripts/fluentd_install.sh|125 col 96| Double quote to prevent globbing and word splitting.
cn/deploy/scripts/fluentd_install.sh|126 col 2| Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
cn/deploy/scripts/fluentd_install.sh|131 col 2| Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
cn/deploy/scripts/fluentd_install.sh|137 col 2| Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
cn/deploy/scripts/script.sh|1 col 1| Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
cn/deploy/scripts/script.sh|12 col 7| Double quote to prevent globbing and word splitting.
cn/deploy/scripts/script.sh|13 col 36| Double quote to prevent globbing and word splitting.
cn/deploy/scripts/script.sh|14 col 12| Quote this to prevent word splitting.
cn/deploy/scripts/script.sh|14 col 21| Quote this to prevent word splitting.
cn/deploy/scripts/script.sh|14 col 30| Double quote to prevent globbing and word splitting.
orc8r/cloud/docker/fluentd_daemon/entrypoint.sh|4 col 30| Double quote to prevent globbing and word splitting.
orc8r/cloud/docker/fluentd_daemon/entrypoint.sh|4 col 93| Double quote to prevent globbing and word splitting.
orc8r/cloud/docker/wait-for-it.sh|37 col 19| Double quote to prevent globbing and word splitting.
orc8r/cloud/docker/wait-for-it.sh|37 col 35| Double quote to prevent globbing and word splitting.
orc8r/cloud/docker/wait-for-it.sh|40 col 30| Double quote to prevent globbing and word splitting.
orc8r/cloud/docker/wait-for-it.sh|40 col 46| Double quote to prevent globbing and word splitting.
orc8r/cloud/docker/wait-for-it.sh|50 col 12| Double quote to prevent globbing and word splitting.
orc8r/cloud/docker/wait-for-it.sh|57 col 41| Double quote to prevent globbing and word splitting.
orc8r/cloud/docker/wait-for-it.sh|57 col 60| Double quote to prevent globbing and word splitting.
orc8r/cloud/docker/wait-for-it.sh|57 col 86| Double quote to prevent globbing and word splitting.
orc8r/cloud/docker/wait-for-it.sh|57 col 109| Double quote to prevent globbing and word splitting.
orc8r/cloud/docker/wait-for-it.sh|57 col 135| Double quote to prevent globbing and word splitting.
orc8r/cloud/docker/wait-for-it.sh|59 col 41| Double quote to prevent globbing and word splitting.
orc8r/cloud/docker/wait-for-it.sh|59 col 60| Double quote to prevent globbing and word splitting.
orc8r/cloud/docker/wait-for-it.sh|59 col 78| Double quote to prevent globbing and word splitting.
orc8r/cloud/docker/wait-for-it.sh|59 col 101| Double quote to prevent globbing and word splitting.
orc8r/cloud/docker/wait-for-it.sh|59 col 127| Double quote to prevent globbing and word splitting.
orc8r/cloud/docker/wait-for-it.sh|62 col 22| Use single quotes, otherwise this expands now rather than when signalled.
orc8r/cloud/docker/wait-for-it.sh|76 col 29| Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.
orc8r/cloud/docker/wait-for-it.sh|147 col 35| Double quote to prevent globbing and word splitting.
orc8r/cloud/docker/wait-for-it.sh|147 col 86| Double quote to prevent globbing and word splitting.
orc8r/cloud/docker/wait-for-it.sh|171 col 7| Expanding an array without an index only gives the first element.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|2 col 3| Not following: orc8r_settings: openBinaryFile: does not exist (No such file or directory)
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|19 col 1| Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|21 col 38| dns_domain is referenced but not assigned.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|21 col 38| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|22 col 47| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|25 col 12| namespace is referenced but not assigned.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|25 col 12| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|35 col 12| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|40 col 12| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|46 col 1| Use a ( subshell ) to avoid having to cd back.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|47 col 12| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|73 col 74| db_root_password is referenced but not assigned.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|73 col 74| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|76 col 9| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|77 col 9| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|78 col 9| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|79 col 9| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|80 col 9| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|81 col 9| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|83 col 9| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|85 col 8| Declare and assign separately to avoid masking return values.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|85 col 29| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|86 col 8| Declare and assign separately to avoid masking return values.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|86 col 29| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|88 col 12| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|88 col 32| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|89 col 12| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|89 col 32| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|89 col 75| admin_email is referenced but not assigned.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|89 col 75| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|89 col 88| admin_password is referenced but not assigned.
orc8r/cloud/deploy/bare-metal/deploy_charts.sh|89 col 88| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/bare-metal/deploy.sh|1 col 1| Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
orc8r/cloud/deploy/bare-metal/deploy.sh|8 col 1| Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
orc8r/cloud/deploy/bare-metal/deploy.sh|14 col 8| Not following: .venv/bin/activate: openBinaryFile: does not exist (No such file or directory)
orc8r/cloud/deploy/bare-metal/deploy.sh|26 col 137| Double quote array expansions to avoid re-splitting elements.
orc8r/cloud/deploy/bare-metal/deploy.sh|38 col 2| Use a ( subshell ) to avoid having to cd back.
orc8r/cloud/deploy/bare-metal/deploy.sh|40 col 29| sudo doesn't affect redirects. Use ..| sudo tee file
orc8r/cloud/deploy/bare-metal/make_magma_pvcs.sh|51 col 45| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/bare-metal-ansible/deploy.sh|1 col 1| Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
orc8r/cloud/deploy/bare-metal-ansible/deploy.sh|19 col 1| Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
orc8r/cloud/deploy/bare-metal-ansible/deploy.sh|25 col 1| Use a ( subshell ) to avoid having to cd back.
orc8r/cloud/deploy/bare-metal-ansible/deploy.sh|29 col 8| Not following: .venv/bin/activate: openBinaryFile: does not exist (No such file or directory)
orc8r/cloud/deploy/bare-metal-ansible/deploy.sh|40 col 165| Double quote array expansions to avoid re-splitting elements.
orc8r/cloud/deploy/bare-metal-ansible/deploy.sh|42 col 59| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/bare-metal-ansible/roles/magma/orc8r/files/make_magma_pvcs.sh|52 col 25| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/scripts/self_sign_certs.sh|52 col 3| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/scripts/self_sign_certs.sh|61 col 134| Double quote to prevent globbing and word splitting.
orc8r/cloud/deploy/scripts/self_sign_certs.sh|67 col 33| Double quote to prevent globbing and word splitting.
orc8r/tools/docker/publish.sh|47 col 10| Quote this to prevent word splitting.
orc8r/tools/docker/install_gateway.sh|29 col 9| Double quote to prevent globbing and word splitting.
orc8r/tools/docker/install_gateway.sh|66 col 8| Not following: .env: openBinaryFile: does not exist (No such file or directory)
orc8r/tools/docker/install_gateway.sh|158 col 6| Use -n instead of ! -z.
orc8r/tools/docker/install_gateway.sh|158 col 37| Use -n instead of ! -z.
orc8r/tools/docker/install_gateway.sh|158 col 68| Use -n instead of ! -z.
orc8r/tools/docker/recreate_services.sh|19 col 8| Not following: /var/opt/magma/docker/.env: openBinaryFile: does not exist (No such file or directory)
orc8r/tools/helm/package.sh|76 col 5| Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
orc8r/tools/packer/create-aws-ami.sh|6 col 1| Double quote to prevent globbing and word splitting.
orc8r/tools/packer/vagrant-box-upload.sh|9 col 16| Double quote to prevent globbing and word splitting.
orc8r/tools/packer/scripts/ansible.sh|18 col 14| echo may not expand escape sequences. Use printf.
orc8r/tools/packer/scripts/code_deploy.sh|17 col 14| echo may not expand escape sequences. Use printf.
.devcontainer/library-scripts/common-debian.sh|34 col 25| Double quote array expansions to avoid re-splitting elements.
.devcontainer/library-scripts/common-debian.sh|35 col 18| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|54 col 12| ShellCheck can't follow non-constant source. Use a directive to specify location.
.devcontainer/library-scripts/common-debian.sh|63 col 46| Use find instead of ls to better handle non-alphanumeric filenames.
.devcontainer/library-scripts/common-debian.sh|113 col 11| Use -n instead of ! -z.
.devcontainer/library-scripts/common-debian.sh|120 col 15| Use -n instead of ! -z.
.devcontainer/library-scripts/common-debian.sh|123 col 17| Use -n instead of ! -z.
.devcontainer/library-scripts/common-debian.sh|130 col 48| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|151 col 10| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|153 col 70| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|154 col 24| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|154 col 34| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|155 col 23| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|155 col 33| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|157 col 70| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|158 col 23| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|158 col 33| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|163 col 18| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|165 col 24| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|165 col 34| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|168 col 36| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|168 col 49| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|170 col 36| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|170 col 52| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|170 col 65| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|176 col 10| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|176 col 63| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|177 col 31| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|284 col 14| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|291 col 9| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|291 col 26| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|292 col 92| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|294 col 61| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|295 col 18| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|296 col 37| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|298 col 61| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|299 col 18| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|300 col 36| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|303 col 8| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|307 col 16| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|307 col 32| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|308 col 18| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|308 col 30| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/common-debian.sh|308 col 42| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/docker-debian.sh|28 col 25| Double quote array expansions to avoid re-splitting elements.
.devcontainer/library-scripts/docker-debian.sh|29 col 18| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/docker-debian.sh|37 col 44| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/docker-debian.sh|44 col 46| Use find instead of ls to better handle non-alphanumeric filenames.
.devcontainer/library-scripts/docker-debian.sh|68 col 104| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/docker-debian.sh|73 col 54| Quote this to prevent word splitting.
.devcontainer/library-scripts/docker-debian.sh|73 col 143| Double quote to prevent globbing and word splitting.
.devcontainer/library-scripts/docker-debian.sh|171 col 7| Double quote to prevent globbing and word splitting.
feg/radius/src/run.sh|25 col 10| Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-sw.sh|20 col 14| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh|44 col 89| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh|45 col 51| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh|46 col 54| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh|56 col 14| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh|56 col 26| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh|68 col 7| Use -n instead of ! -z.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|1 col 1| Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|13 col 23| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|15 col 9| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|16 col 9| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|18 col 14| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|19 col 11| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|22 col 14| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|23 col 13| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|28 col 12| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|32 col 21| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|36 col 16| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|37 col 20| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|41 col 73| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|41 col 99| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|43 col 34| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|44 col 22| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|44 col 56| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|44 col 84| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|45 col 33| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|47 col 23| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|50 col 16| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|51 col 23| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|51 col 103| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|52 col 23| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|66 col 23| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|1 col 1| Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|16 col 15| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|18 col 14| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|20 col 38| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|23 col 27| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|25 col 17| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|26 col 17| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|27 col 17| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|29 col 17| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|29 col 54| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|29 col 65| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|29 col 81| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|37 col 17| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|37 col 68| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|38 col 13| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|39 col 16| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|41 col 20| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|46 col 14| Iterating over ls output is fragile. Use globs.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|49 col 9| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|57 col 16| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|57 col 61| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|60 col 5| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/envoy-tests/setup-net-http.sh|5 col 1| envoy_port appears unused. Verify use (or export if used externally).
lte/gateway/python/magma/pipelined/tests/envoy-tests/setup-envoy-cntr.sh|3 col 1| envoy_ns appears unused. Verify use (or export if used externally).
lte/gateway/python/magma/pipelined/tests/envoy-tests/envoy-service.sh|43 col 64| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/envoy-tests/install-envoy.sh|1 col 1| Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
lte/gateway/python/magma/pipelined/tests/envoy-tests/setup-envoy.sh|3 col 1| envoy_ns appears unused. Verify use (or export if used externally).
lte/gateway/python/magma/pipelined/tests/envoy-tests/pkt-routing-setup.sh|1 col 1| Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
lte/gateway/release/upgrade_magma.sh|15 col 5| read without -r will mangle backslashes.
lte/gateway/release/build-magma.sh|19 col 1| SCRIPT_DIR appears unused. Verify use (or export if used externally).
lte/gateway/release/build-magma.sh|58 col 5| CERT_FILE appears unused. Verify use (or export if used externally).
lte/gateway/release/build-magma.sh|70 col 43| Double quote to prevent globbing and word splitting.
lte/gateway/release/build-magma.sh|87 col 40| Double quote to prevent globbing and word splitting.
... (Too many findings. Dropped some findings)

Annotations

Check warning on line 22 in orc8r/tools/packer/scripts/third_party/chef_bento/cleanup_ubuntu.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] orc8r/tools/packer/scripts/third_party/chef_bento/cleanup_ubuntu.sh#L22 <ShellCheck.SC2046>

Quote this to prevent word splitting.
Raw output
./orc8r/tools/packer/scripts/third_party/chef_bento/cleanup_ubuntu.sh:22:15: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)

Check notice on line 22 in orc8r/tools/packer/scripts/third_party/chef_bento/cleanup_ubuntu.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] orc8r/tools/packer/scripts/third_party/chef_bento/cleanup_ubuntu.sh#L22 <ShellCheck.SC2006>

Use $(...) notation instead of legacy backticks `...`.
Raw output
./orc8r/tools/packer/scripts/third_party/chef_bento/cleanup_ubuntu.sh:22:15: info: Use $(...) notation instead of legacy backticks `...`. (ShellCheck.SC2006)

Check notice on line 23 in orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh#L23 <ShellCheck.SC2004>

$/${} is unnecessary on arithmetic variables.
Raw output
./orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh:23:10: info: $/${} is unnecessary on arithmetic variables. (ShellCheck.SC2004)

Check notice on line 29 in orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh#L29 <ShellCheck.SC2004>

$/${} is unnecessary on arithmetic variables.
Raw output
./orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh:29:10: info: $/${} is unnecessary on arithmetic variables. (ShellCheck.SC2004)

Check notice on line 34 in orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh#L34 <ShellCheck.SC2006>

Use $(...) notation instead of legacy backticks `...`.
Raw output
./orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh:34:11: info: Use $(...) notation instead of legacy backticks `...`. (ShellCheck.SC2006)

Check notice on line 44 in orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh#L44 <ShellCheck.SC2006>

Use $(...) notation instead of legacy backticks `...`.
Raw output
./orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh:44:15: info: Use $(...) notation instead of legacy backticks `...`. (ShellCheck.SC2006)

Check notice on line 44 in orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh#L44 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh:44:46: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check warning on line 12 in .devcontainer/post-create-commands.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] .devcontainer/post-create-commands.sh#L12 <ShellCheck.SC2046>

Quote this to prevent word splitting.
Raw output
./.devcontainer/post-create-commands.sh:12:51: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)

Check notice on line 58 in lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh#L58 <ShellCheck.SC2236>

Use -n instead of ! -z.
Raw output
./lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh:58:7: info: Use -n instead of ! -z. (ShellCheck.SC2236)

Check warning on line 59 in lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh#L59 <ShellCheck.SC2027>

The surrounding quotes actually unquote this. Remove or escape them.
Raw output
./lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh:59:33: warning: The surrounding quotes actually unquote this. Remove or escape them. (ShellCheck.SC2027)

Check notice on line 59 in lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh#L59 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh:59:33: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check warning on line 18 in lte/gateway/docker/ghz/publish.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] lte/gateway/docker/ghz/publish.sh#L18 <ShellCheck.SC2140>

Word is of the form "A"B"C" (B indicated). Did you mean "ABC" or "A\"B\"C"?
Raw output
./lte/gateway/docker/ghz/publish.sh:18:29: warning: Word is of the form "A"B"C" (B indicated). Did you mean "ABC" or "A\"B\"C"? (ShellCheck.SC2140)

Check notice on line 16 in lte/gateway/deploy/roles/agw_docker/files/agw_upgrade.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] lte/gateway/deploy/roles/agw_docker/files/agw_upgrade.sh#L16 <ShellCheck.SC1091>

Not following: /var/opt/magma/docker/.env: openBinaryFile: does not exist (No such file or directory)
Raw output
./lte/gateway/deploy/roles/agw_docker/files/agw_upgrade.sh:16:8: info: Not following: /var/opt/magma/docker/.env: openBinaryFile: does not exist (No such file or directory) (ShellCheck.SC1091)

Check notice on line 23 in lte/gateway/deploy/roles/agw_docker/files/agw_upgrade.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] lte/gateway/deploy/roles/agw_docker/files/agw_upgrade.sh#L23 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./lte/gateway/deploy/roles/agw_docker/files/agw_upgrade.sh:23:22: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check notice on line 45 in lte/gateway/deploy/roles/magma_test/files/update_package.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] lte/gateway/deploy/roles/magma_test/files/update_package.sh#L45 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./lte/gateway/deploy/roles/magma_test/files/update_package.sh:45:18: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check notice on line 17 in third_party/build/bin/bcc_build.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] third_party/build/bin/bcc_build.sh#L17 <ShellCheck.SC1091>

Not following: ./../lib/util.sh: openBinaryFile: does not exist (No such file or directory)
Raw output
./third_party/build/bin/bcc_build.sh:17:8: info: Not following: ./../lib/util.sh: openBinaryFile: does not exist (No such file or directory) (ShellCheck.SC1091)

Check warning on line 22 in third_party/build/bin/bcc_build.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] third_party/build/bin/bcc_build.sh#L22 <ShellCheck.SC2034>

VERSION appears unused. Verify use (or export if used externally).
Raw output
./third_party/build/bin/bcc_build.sh:22:1: warning: VERSION appears unused. Verify use (or export if used externally). (ShellCheck.SC2034)

Check notice on line 18 in third_party/build/bin/aioh2_build.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] third_party/build/bin/aioh2_build.sh#L18 <ShellCheck.SC1091>

Not following: ./../lib/util.sh: openBinaryFile: does not exist (No such file or directory)
Raw output
./third_party/build/bin/aioh2_build.sh:18:8: info: Not following: ./../lib/util.sh: openBinaryFile: does not exist (No such file or directory) (ShellCheck.SC1091)

Check notice on line 37 in third_party/build/bin/aioh2_build.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] third_party/build/bin/aioh2_build.sh#L37 <ShellCheck.SC1091>

Not following: env/bin/activate: openBinaryFile: does not exist (No such file or directory)
Raw output
./third_party/build/bin/aioh2_build.sh:37:8: info: Not following: env/bin/activate: openBinaryFile: does not exist (No such file or directory) (ShellCheck.SC1091)

Check warning on line 15 in third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh#L15 <ShellCheck.SC2046>

Quote this to prevent word splitting.
Raw output
./third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh:15:38: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)

Check notice on line 15 in third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh#L15 <ShellCheck.SC2006>

Use $(...) notation instead of legacy backticks `...`.
Raw output
./third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh:15:38: info: Use $(...) notation instead of legacy backticks `...`. (ShellCheck.SC2006)

Check warning on line 39 in third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh#L39 <ShellCheck.SC2046>

Quote this to prevent word splitting.
Raw output
./third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh:39:38: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)

Check notice on line 39 in third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh#L39 <ShellCheck.SC2006>

Use $(...) notation instead of legacy backticks `...`.
Raw output
./third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh:39:38: info: Use $(...) notation instead of legacy backticks `...`. (ShellCheck.SC2006)

Check warning on line 51 in third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh#L51 <ShellCheck.SC2046>

Quote this to prevent word splitting.
Raw output
./third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh:51:42: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)

Check notice on line 51 in third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh#L51 <ShellCheck.SC2006>

Use $(...) notation instead of legacy backticks `...`.
Raw output
./third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh:51:42: info: Use $(...) notation instead of legacy backticks `...`. (ShellCheck.SC2006)