Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for huggingface_hub>=0.25.0 #73

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

tomaarsen
Copy link
Contributor

Hello!

Pull Request overview

  • Add support for huggingface_hub>=0.25.0

Details

Since huggingface_hub v0.25.0, the huggingface_hub.utils._errors file was removed, see huggingface/huggingface_hub#2474. Rather than only using from huggingface_hub.errors import RepositoryNotFoundError and requiring at least huggingface_hub>=0.25.0, this fix allows for all recent versions to work.

cc @Wauplin to inform you of the breaking change as it wasn't explicitly mentioned in your release notes (although I recognize that you could argue that _errors was a private file that shouldn't be used outside of hf_hub itself).

  • Tom Aarsen

@Pringled Pringled self-requested a review October 10, 2024 11:28
@Pringled Pringled self-assigned this Oct 10, 2024
Copy link
Member

@Pringled Pringled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, wasn't aware of this change so thanks for fixing this!

@Pringled Pringled merged commit 965025c into MinishLab:main Oct 10, 2024
@Wauplin
Copy link

Wauplin commented Oct 10, 2024

cc @Wauplin to inform you of the breaking change as it wasn't explicitly mentioned in your release notes (although I recognize that you could argue that _errors was a private file that shouldn't be used outside of hf_hub itself).

Yes indeed, we don't communicate in breaking changes of internal modules. Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants