Added Boat #592
Open
Added Boat #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added benefit for boats to make them useful
Litorom
requested review from
Makkkkus,
BenCheung0422 and
ChristofferHolmesland
|
Ah, CodeQL reminds you that the input system has been changed, do consider syncing your branch to solve this. |
El-Virus
requested changes
Dec 30, 2023
|
Right, you'll also have to modify your code to use the new input system. |
|
What about following the rule of "everything costs stamina"? Using boat on water still costs stamina, but it consumes stamina per a certain distance travelled continuously. |
Makkkkus
reviewed
Jan 25, 2024
|
For people interested, this is my version of implementation for boat: https://github.com/BenCheung0422/minicraft-plus-revived/tree/boat |
BenCheung0422
added
the
F-Addition
BenCheung0422
added
the
G-Expansion
# Conflicts: # src/client/java/minicraft/item/Items.java # src/client/java/minicraft/item/Recipes.java # src/client/java/minicraft/saveload/Load.java
|
It is a question to whether to consume stamina (by travelling ticks). Anyway, Litorom has merged my branch to this pull request and I have also made some further changes. |
Fix issues: - player is kicked off from boat (when out of stamina/not moved) - player dir not synced with boat when not moved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ultimate and so useful feature has been added. Introducing the boat, the float on water that consumes no stamina!
All jokes aside:
Additions:
Notes: