Clean up usages of Random in chests #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like it fixes another bug I discovered today, the dungeon chests in structures generate empty. Please fix your code and test and I’ll merge it |
Makkkkus
reviewed
Jan 7, 2024
# Conflicts: # src/client/java/minicraft/entity/furniture/DungeonChest.java # src/client/java/minicraft/item/Inventory.java # src/client/java/minicraft/level/Structure.java # src/client/java/minicraft/saveload/LegacyLoad.java # src/client/java/minicraft/saveload/Load.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When populating chests, as it involves world generation, it should also include the world generation random provider when using randoms. This fixes this problem. Unused
Inventory#tryAddmethods are also removed. All chests should be the same for the same seed in initialization now.