Player inventory item entry ordering and stacking functions #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/client/java/minicraft/item/Recipe.java
|
This feature has also been mentioned in |
BenCheung0422
removed
the
Won't fix
|
Denied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As there has already been entry limit on the player inventory, item stack operations should be introduced to make support to the inventory limitation. This adds functionalities of item entry ordering (by shifting entries/stacks) and stacking (stackable items that have spare space from maximum stacking size). The corresponding key bindings are
SHIFT+CURSOR-[UP|DOWN]andCTRL+CURSOR-[UP|DOWN]. This also fixes the problems that stackable items always adding at the end of the inventory even it has indicated to other slots, found by the item re-adding feature. Currently, if the target slot is not specified, all items will be attempted to be added at the end of the inventory; otherwise, if the item is stackable, the items (occupying 1 slot only ifsingleton) are attempted to be added to the target slot, or else (ifsingletonis false (in player inventory menu or container menu), then first attempt to add to the following next slot) the remaining items are attempted to be added at the end of the inventory. Redundant numeral checks are also reduced fromInventory#addand a nullable item object is returned for the check. When holdingCTRL, the added items attempt to add as the unspecified slot.