Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use common retry policy builder function #1247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -242,15 +242,8 @@ internal virtual async Task<Exception> InternalApplyTableChangesAsync(ScopeInfo

this.Logger.LogInformation("[InternalApplyTableChangesAsync]. Directory name {DirectoryName}. BatchParts count {BatchPartsInfoCount}", message.Changes.DirectoryName, message.Changes.BatchPartsInfo.Count);

// If we have a transient error happening, and we are rerunning the tranaction,
// raising an interceptor
var onRetry = new Func<Exception, int, TimeSpan, object, Task>((ex, cpt, ts, arg) =>
this.InterceptAsync(new TransientErrorOccuredArgs(context, connection, ex, cpt, ts), progress, cancellationToken).AsTask());

// Defining my retry policy
var retryPolicy = this.Options.TransactionMode != TransactionMode.AllOrNothing
? SyncPolicy.WaitAndRetryForever(retryAttempt => TimeSpan.FromMilliseconds(500 * retryAttempt), (ex, arg) => this.Provider.ShouldRetryOn(ex), onRetry)
: SyncPolicy.WaitAndRetry(0, TimeSpan.Zero);
var retryPolicy = this.BuildSyncPolicy(context, connection, progress, cancellationToken);

var applyChangesPolicyResult = await retryPolicy.ExecuteAsync(
async () =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,8 @@ public partial class LocalOrchestrator : BaseOrchestrator
DbConnection connection = default, DbTransaction transaction = default,
IProgress<ProgressArgs> progress = null, CancellationToken cancellationToken = default)
{
// If we have a transient error happening, and we are rerunning the tranaction,
// raising an interceptor
var onRetry = new Func<Exception, int, TimeSpan, object, Task>((ex, cpt, ts, arg) =>
this.InterceptAsync(new TransientErrorOccuredArgs(context, connection, ex, cpt, ts), progress, cancellationToken).AsTask());

// Defining my retry policy
SyncPolicy retryPolicy = this.Options.TransactionMode == TransactionMode.AllOrNothing
? retryPolicy = SyncPolicy.WaitAndRetryForever(retryAttempt => TimeSpan.FromMilliseconds(500 * retryAttempt), (ex, arg) => this.Provider.ShouldRetryOn(ex), onRetry)
: retryPolicy = SyncPolicy.WaitAndRetry(0, TimeSpan.Zero);
var retryPolicy = this.BuildSyncPolicy(context, connection, progress, cancellationToken);

// Execute my OpenAsync in my policy context
var applyChangesResult = await retryPolicy.ExecuteAsync<(SyncContext Context, ClientSyncChanges ClientSyncChange, ScopeInfoClient CScopeInfoClient)>(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,8 @@ public partial class RemoteOrchestrator : BaseOrchestrator
// Previous sync errors
BatchInfo lastSyncErrorsBatchInfo = null;

// If we have a transient error happening, and we are rerunning the tranaction,
// raising an interceptor
var onRetry = new Func<Exception, int, TimeSpan, object, Task>((ex, cpt, ts, arg) =>
this.InterceptAsync(new TransientErrorOccuredArgs(context, connection, ex, cpt, ts), progress, cancellationToken).AsTask());

// Defining my retry policy
SyncPolicy retryPolicy = this.Options.TransactionMode == TransactionMode.AllOrNothing
? retryPolicy = SyncPolicy.WaitAndRetryForever(retryAttempt => TimeSpan.FromMilliseconds(500 * retryAttempt), (ex, arg) => this.Provider.ShouldRetryOn(ex), onRetry)
: retryPolicy = SyncPolicy.WaitAndRetry(0, TimeSpan.Zero);
var retryPolicy = this.BuildSyncPolicy(context, connection, progress, cancellationToken);

await retryPolicy.ExecuteAsync(
async () =>
Expand Down
26 changes: 26 additions & 0 deletions Projects/Dotmim.Sync.Core/Orchestrators/BaseOrchestrator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -445,5 +445,31 @@ internal SyncException GetSyncError(SyncContext context, Exception exception, st
throw this.GetSyncError(context, ex);
}
}

/// <summary>
/// Builds a synchronization policy based on the TransactionMode of this orchestrator.
/// </summary>
/// <param name="context">The synchronization context.</param>
/// <param name="connection">The database connection.</param>
/// <param name="progress">The progress reporter.</param>
/// <param name="cancellationToken">The cancellation token.</param>
/// <param name="retryIntervalMilliseconds">The interval in milliseconds between retry attempts. Default is 500 milliseconds.</param>
/// <returns>A <see cref="SyncPolicy"/> configured according to the transaction mode.</returns>
/// <exception cref="NotImplementedException">Thrown when an unsupported transaction mode is encountered.</exception>
protected SyncPolicy BuildSyncPolicy(SyncContext context, DbConnection connection, IProgress<ProgressArgs> progress, CancellationToken cancellationToken, int retryIntervalMilliseconds = 500)
{
// If we have a transient error happening, and we are rerunning the transaction,
// raising an interceptor
var onRetry = new Func<Exception, int, TimeSpan, object, Task>((ex, cpt, ts, arg) =>
this.InterceptAsync(new TransientErrorOccuredArgs(context, connection, ex, cpt, ts), progress, cancellationToken).AsTask());

return this.Options.TransactionMode switch
{
TransactionMode.AllOrNothing => SyncPolicy.WaitAndRetry(0, TimeSpan.Zero),
TransactionMode.PerBatch => SyncPolicy.WaitAndRetryForever(retryAttempt => TimeSpan.FromMilliseconds(retryIntervalMilliseconds * retryAttempt), (ex, arg) => this.Provider.ShouldRetryOn(ex), onRetry),
TransactionMode.None => SyncPolicy.WaitAndRetryForever(retryAttempt => TimeSpan.FromMilliseconds(retryIntervalMilliseconds * retryAttempt), (ex, arg) => this.Provider.ShouldRetryOn(ex), onRetry),
_ => throw new NotImplementedException(),
};
}
}
}
Loading