Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to robots to obtain nearby experience orbs #3702

Open
wants to merge 7 commits into
base: master-MC1.12
Choose a base branch
from

Conversation

zeng-github01
Copy link

@zeng-github01 zeng-github01 commented Apr 11, 2024

Temporary fix #3289

Existing bug: The format of settings.conf is wrong and cannot be parsed correctly, which will cause a crash.

A temporary fix has been made to this bug. Looks like a past patch oversight caused the crash, so it needs to be reviewed

@zeng-github01 zeng-github01 marked this pull request as draft April 11, 2024 12:18
@zeng-github01 zeng-github01 marked this pull request as ready for review April 12, 2024 05:43
@zeng-github01
Copy link
Author

zeng-github01 commented Apr 12, 2024

It looks like the cause of the crash is two missing configuration entries, something the past patch missed.

@zeng-github01 zeng-github01 changed the title Add ability robot gain experience orb Add ability to robots to obtain nearby experience orbs Apr 12, 2024
@zeng-github01
Copy link
Author

zeng-github01 commented Apr 13, 2024

@asiekierka After investigation, Minecraft does not fire any events when a transaction is triggered. Only some experience orbs will be spawned This problem cannot be fixed through ordinary solutions in the current version.

The only solution might be to add a custom event trigger to “useRecipe” through a mixin or ASM

A feasible method is to imitate this submission and add a logic to absorb experience balls in Trade.scala when the complateTrade judgment is completed, but there may be a lag.

Or just like this PR, giving players the power to customize

@zeng-github01 zeng-github01 marked this pull request as draft April 15, 2024 04:31
@zeng-github01 zeng-github01 marked this pull request as ready for review April 15, 2024 04:57
@zeng-github01
Copy link
Author

@asiekierka The patch has been tested and meets the expected results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant