Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npgsql to 4.0.17 from 4.0.10 #564

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vleslief-ms
Copy link
Contributor

@vleslief-ms vleslief-ms commented Oct 11, 2024

The next release of PowerBI will ship with npgsql 4.0.17 instead of 4.0.10. PostgreSQL connector document should be updated to reflect that.

The next release of PowerBI will ship with npgsql 4.0.16 instead of 4.0.10. PostgreSQL connector document should be updated to reflect that.
@prmerger-automator prmerger-automator bot added the do-not-merge Don't merge this yet label Oct 11, 2024
Copy link
Contributor

@vleslief-ms : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 46e0fa3:

✅ Validation status: passed

File Status Preview URL Details
powerquery-docs/connectors/postgresql.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Oct 11, 2024

@DougKlopfenstein
Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Copy link

@KazimMir KazimMir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor question

powerquery-docs/connectors/postgresql.md Show resolved Hide resolved
@Jak-MS
Copy link
Contributor

Jak-MS commented Oct 14, 2024

@KazimMir @DougKlopfenstein - this is still waiting for release, correct? can you sign off when it's ready for merge? thanks.

@vleslief-ms vleslief-ms changed the title Update npgsql to 4.0.16 from 4.0.10 Update npgsql to 4.0.17 from 4.0.10 Oct 29, 2024
@vleslief-ms
Copy link
Contributor Author

Due to some issues with 4.0.16, PBI Desktop had to be updated to npgsql 4.0.17 instead. Will update PR to reflect that.

Also clarifying when npgsql started to be included and the date of the upgrade to 4.0.17
Copy link
Contributor

Learn Build status updates of commit 48ff390:

✅ Validation status: passed

File Status Preview URL Details
powerquery-docs/connectors/postgresql.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@vleslief-ms
Copy link
Contributor Author

Document has been updated to reflect 4.0.17 version usage. Due to the releases page on npgsql not including a 4.0.17 MSI, I rewrote a little bit of the later paragraph to be more generic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants