Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request fm #143

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

FabienMathieu
Copy link
Contributor

I am a user of VL from the old age and I use it for my work. For my needs, I had to add some functionalities. Here is a list of these:

  • Support of Transform Feedback and associated examples (https://www.opengl.org/wiki/Transform_Feedback)
  • Add support of displaying texte via shaders and support of font atlas (CoreText and CoreFont)
  • Possibility to extrude multiple contours (Extrusion**s** class)
  • Possibility to enable or disable the rasterizer (GL_RASTERIZER_DISCARD)
  • Intersector can intersect lines and points in addition of triangles
  • Creation of lines iterator to iterate over lines in order to look for the intersected ones
  • Creation of triangles and lines accessors, in order to access directly to one of these elements
  • Support of Transform manipulators and associated examples (for transformation gyzmos for example)

I hope I forgot anything. I have begun to develop theses functionalities from the first version of VL (Visualization_Library_SDK-2011.09 I believe). So, I take current master to adapt my modifications.

Feel free to take all or part of my modification to improve VL 2.x. If you need any additional information about my modifications, don't hesitate to ask.

Best regards

Fabien MATHIEU

@MicBosi
Copy link
Owner

MicBosi commented Jan 19, 2017

Thanks Fabien, long time no see :)

I'd be happy to merge all of your improvements. Would you mind splitting the PR in smaller separate ones so I can check and test them individually?

I've just released v2.0-beta so it'd be nice to rebase against that (master).

Also if you have any picture or further explanation of each individual PR it would help a ton, especially for the Extrusions and CoreText/CoreFont :)

Also, I haven't looked at the code yet as it's time to go to bed for me now... but is it at all possible to merge your Extrusions into the existing Extrusion by extending it's API? Same for CoreText/CoreFont --> Text/Font?

All the best and happy new year :)

@FabienMathieu
Copy link
Contributor Author

Thanks for your interest, and happy new year.

That's right that's a huge block of change :). I have quit my job where I used VL for my developments and my boss wanted to know it was possible to merge my change to avoid maintaining our own version of VL internally.

I will split my changes in smaller parts to help you to review my code. I don't think I will be able to provide some picture of the use case, because as I said, I have quit my job for another one, and I don't have access to them. However, I will try to add some explanations about my changes and if possible, I will add an applet to test it.

Concerning my Extrusions, it's indeed a simple extension of the orginal Extrusion. It simply handle with multiple contours, and I add the possibility to get vertex attribute out.

Concerning my CoreText/CoreFont, I based myself on your last work on CoreText some years ago. Unlike Extrusion, I don't think it is possible to just extend the original Text/Font API. My CoreText/CoreFont have some differencies in the API with the original ones because I wanted to use shaders to render text. Moreover, I think there are some functionnalities lacking because I never needed them (border for examples).

Concerning the other changes, it is some basic add of VL functionnalities, like line intersector with lines iterators and accessors, or adds of OpenGL functionnalities (Transform feedback or GL_RASTERIZER_DISCARD).

In all cases, I am very happy to see you keep maintaining and evolving VL.

Best regards

@MicBosi
Copy link
Owner

MicBosi commented Jan 21, 2017

Thanks Fabien is always fun to connect with people who have used VL :) Perhaps the best course of action would be to do one change at a time starting with the simplest ones - whenever you have time, I'm also in no hurry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants