EIP4844 support & Other misc issues fix

[dumdumgoose]

• Upgraded go-ethereum to v1.14.11 to support EIP4844 transaction signing
• Added a new signing type for blob data
• Allows to start servers with different ports (added some extra flags to control that)

This is still under testing, do not merge for now.

[ericlee42]

Is there any difference from randomRangeInclusive?

[dumdumgoose]

@aiden069 told me that the numbers generated by randomRangeInclusive are not in a normal distribution manner, so I rewrote the random generation part with CLT (since this is the only stateless random generation method I can find that will most likely provide a normal distribution result).

Here is the test result:

[ericlee42]

We need to discuss it first.

It's still unfair for a validator with higher power.

[dumdumgoose]

Sure, shall we setup a quick meeting for this? And @aiden069 what's your opinion here?

[ericlee42]

Please move the selection change to a new PR.

[dumdumgoose]

Please move the selection change to a new PR.

Removed, will create a separate PR for selection soon.

[dumdumgoose]

Please move the selection change to a new PR.

@ericlee42 PR for new selection is here

[ericlee42]

Can you explain why we need this?

[dumdumgoose]

There are some differences in RLP decoding in go-ethereum 1.14 and 1.10. The binary data of unsigned transaction does not have r, s and v encoded, if we use tx.UnmarshalBinary provided in go-ethereum 1.14, it will cause an error (too many elements) when decoding. So I copied over the data structures from go-ethereum and set the r, s, v to optional to avoid this error.

[ericlee42]

I don't think so.

Please give an example for it.

[dumdumgoose]

1. Create a dynamic fee tx

2. Decode the transaction with tx.UnmarshalBinary

Also that one thing to notice, I played with different transaction types, it seems that this error will only happens on typed transactions (access list / dynamic fee / blob), not on legacy tx. I guess that's why the previous themis code works, since the txs submitted to MPC were only legacy txs.

[dumdumgoose]

Same tx data with the optional decoding:

[dumdumgoose]

I guess this might be the reason? But I'm not sure the relation between gencodec tag and RLP decode.

[ericlee42]

I just checked the code of the ether.js, it doesn't add the sig fields to the rlp bytes

https://github.com/ethers-io/ethers.js/blob/9e7e7f3e2f2d51019aaa782e6290e079c38332fb/src.ts/transaction/transaction.ts#L386-L389

But it should work for geth

package main

import (
	"math/big"

	"github.com/ethereum/go-ethereum/common"
	"github.com/ethereum/go-ethereum/core/types"
)

func main() {
	var a common.Address
	tx1 := types.NewTx(&types.DynamicFeeTx{
		ChainID:   big.NewInt(1),
		GasTipCap: big.NewInt(1e9),
		GasFeeCap: big.NewInt(1e9),
		Gas:       1e5,
		To:        &a,
		Value:     big.NewInt(0),
	})

	tx1Raw, err := tx1.MarshalBinary()
	if err != nil {
		panic(err)
	}

	var tx2 types.Transaction
	if err := tx2.UnmarshalBinary(tx1Raw); err != nil {
		panic(err)
	}
}

Fair enough, we can accept the change.