Support provhdr on Stratis altcoin #787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebase? |
NBitcoin/RPC/RestClient.cs
Outdated
| @@ -76,7 +76,7 @@ public RestClient(Uri address, Network network) | |||
| /// <param name="blockId">The block identifier.</param> | |||
| /// <returns>Given a block hash (id) returns the requested block object.</returns> | |||
| /// <exception cref="System.ArgumentNullException">blockId cannot be null.</exception> | |||
| public async Task<Block> GetBlockAsync(uint256 blockId) | |||
| public async Task<Block> GetBlockAsync(uint256 blockId, int verbosity = 0) | |||
There was a problem hiding this comment.
Both RestClient and RPCClient inherit from IBlockRepository, which defines a method Task<Block> GetBlockAsync(uint256 blockId, int verbosity);. So I'm not sure what the best approach would be, unless perhaps the enum was renamed and moved to be used by both implementations.
This reverts commit 562dca4.
* Implement uptime RPC * Make test faster * Reuse function * Improve order: Place uptime after the "stop" just like it's in Bitcoin Core's help * Add back whitespace to improve diff * Remove time sensitive test.
* Write test. * Ensure backwards compatibility of getblockchaininfo
* Write test. * Ensure backwards compatibility of getblockchaininfo * Ensure testmempoolaccept backwards compatibility
* Fix: "Invalid Hex String" exception for DogeCash * Increase patch number
* Genesis fix for NBXplorer sync * Base58 format ordering
|
I've got this branch into a mess, reopening as a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to supersede #692