Override Script Eval Context for Elements #1009
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds: CHECKSIGFROMSTACK, CHECKSIGFROMSTACKVERIFY Re-enables: CAT I haven't figured out a good way to plug this into the system painlessly though. I think I need to add `CreateScriptEvaluationContext` to `ConsensusFactory` but that requires I need to do method signature changes across the lib
|
@Kukks do we need this btw? I am not sure it makes sense to validate the scripts with NBitcoin, even if we support it. |
NicolasDorier
force-pushed
the
master
branch
from
878114e
to
24301c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds: CHECKSIGFROMSTACK, CHECKSIGFROMSTACKVERIFY
Re-enables: CAT
I haven't figured out a good way to plug this into the system painlessly though. I think I need to add
CreateScriptEvaluationContexttoConsensusFactorybut that requires I need to do method signature changes across the lib