Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds GoogleService.plist creation during build process #11863

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

feat: adds GoogleService.plist creation during build process #11863

wants to merge 19 commits into from
+197 −24

Conversation

Jonathansoufer
Copy link
Contributor

Description

This PR address a need for creating GoogleServices-info.plist file at build process thus avoiding leaving project details exposed. Although this isn't an issue as stated here and here, we're just trying to minimize risk even when they're very low already.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Screenshot 2024-10-18 at 11 27 28

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform team-notifications Notifications team labels Oct 18, 2024
@Jonathansoufer Jonathansoufer self-assigned this Oct 18, 2024
@Jonathansoufer Jonathansoufer requested review from a team as code owners October 18, 2024 10:28
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Jonathansoufer Jonathansoufer added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2aa558c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/58e22e5b-0159-44cc-81bb-2880df003499

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Jonathansoufer Jonathansoufer added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6208509
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1c96ecb8-0655-481d-94fd-23ec7f9959ab

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Jonathansoufer Jonathansoufer removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 19, 2024
@Jonathansoufer Jonathansoufer added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 19, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 99dc3a2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e7c70915-e5f0-4761-82b4-2de0b5452beb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Jonathansoufer Jonathansoufer removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 21, 2024
@Jonathansoufer Jonathansoufer added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ad20caf
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/667d6e47-c5d8-4ee4-aec7-1e59bb582aeb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Jonathansoufer Jonathansoufer added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 47c8207
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8e7233a4-e02b-4f8e-a51f-eaec0ba12288

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Jonathansoufer Jonathansoufer removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 21, 2024
@Jonathansoufer Jonathansoufer added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 90335e3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8bfaf0bc-d671-4a45-9d34-b8b5d99daa33

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Jonathansoufer Jonathansoufer added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8be4229
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/df5b856d-ebc3-4f56-ab9f-fa216cbb03c5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Jonathansoufer Jonathansoufer

Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-notifications Notifications team
Projects
PR review queue
Status: Needs dev review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jonathansoufer @cortisiko