-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor header for tokens #11855
base: main
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise🔄🔄🔄 Commit hash: 51ff159 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🚀 LGTM!
Bitrise❌❌❌ Commit hash: 81e980e Note
Tip
|
Bitrise❌❌❌ Commit hash: c824377 Note
Tip
|
Bitrise❌❌❌ Commit hash: 94228f0 Note
Tip
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled down, and looks good! The snapshot updates also look reasonable to me.
It looks like for certain networks, the left icon ...
is non-functional. I wonder what the lift would be to not show that icon if it doesn't pop the BottomSheet
when pressed?
Screen.Recording.2024-10-18.at.12.00.55.PM.mov
Everything looks good to me except this issue. I was able to reproduce it as well |
does this behavior currently exist in prod? |
Description
This PR updates the Header for the Token details view, based on this design update by @amandaye0h . Specifically
ButtonIcon
component with the large sizeRelated issues
Fixes: #11854
Manual testing steps
Screenshots/Recordings
Before
After
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-10-17.at.15.48.18.mp4
Pre-merge author checklist
Pre-merge reviewer checklist