Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Implement retry logic for downloading nvm in Bitrise #11833

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented Oct 17, 2024

Description

The purpose of this PR is to add a retry mechanism for downloading nvm to prevent the prep_environment step in bitrise from premature failing which in turn cause a false preception that the e2e tests are flakey. I used wget's --tries and--waitretryoptions to automatically attempt the download up to three times with a five-second wait between retries while downloading nvm.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko added team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 17, 2024
@cortisiko cortisiko self-assigned this Oct 17, 2024
@cortisiko cortisiko requested review from a team as code owners October 17, 2024 00:05
@cortisiko cortisiko linked an issue Oct 17, 2024 that may be closed by this pull request
9 tasks
Copy link
Contributor

github-actions bot commented Oct 17, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 65354a0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0ac4324d-4223-4fd6-b45f-06f9abf32083

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko marked this pull request as draft October 17, 2024 00:31
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure about the spaces increment additions?

Copy link

sonarcloud bot commented Oct 22, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

CI: Add retry logic to prevent builds from failing while installing nvm
2 participants