-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Implement retry logic for downloading nvm in Bitrise #11833
base: main
Are you sure you want to change the base?
chore: Implement retry logic for downloading nvm in Bitrise #11833
Conversation
Bitrise✅✅✅ Commit hash: 65354a0 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure about the spaces increment additions?
Quality Gate passedIssues Measures |
Description
The purpose of this PR is to add a retry mechanism for downloading nvm to prevent the prep_environment step in bitrise from premature failing which in turn cause a false preception that the e2e tests are flakey. I used wget's
--tries
and--waitretry
options to automatically attempt the download up to three times with a five-second wait between retries while downloading nvm.Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist