Merge branch 'main' into fix-2804-right-margin-was-to-wide-and-looked…

…-broken-compared-to-left-margin
MetaMask · Oct 22, 2024 · a165f93 · a165f93
2 parents a615305 + f2f84ed
commit a165f93
Show file tree

Hide file tree

Showing 53 changed files with 1,738 additions and 3,014 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -51,6 +51,12 @@ module.exports = {
       rules: {
         // under discussion
         'no-unused-vars': 'off',
+        'react/no-unstable-nested-components': [
+          'warn',
+          {
+            allowAsProps: true,
+          },
+        ],
       },
     },
     {

diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -6,5 +6,7 @@
   "cucumberautocomplete.steps": ["wdio/step-definitions/**/*.js"],
   "cucumberautocomplete.syncfeatures": "wdio/to/features/*.feature",
   "cucumberautocomplete.strictGherkinCompletion": true,
-  "typescript.tsdk": "node_modules/typescript/lib"
+  "typescript.tsdk": "node_modules/typescript/lib",
+  "javascript.preferences.importModuleSpecifier": "relative",
+  "typescript.preferences.importModuleSpecifier": "relative"
 }
diff --git a/app/actions/onboarding/index.ts b/app/actions/onboarding/index.ts
@@ -25,4 +25,4 @@ export function clearOnboardingEvents(): ClearEventsAction {
   return {
     type: CLEAR_EVENTS,
   };
-}
+}
diff --git a/app/component-library/components-temp/Contracts/ContractBoxBase/ContractBoxBase.tsx b/app/component-library/components-temp/Contracts/ContractBoxBase/ContractBoxBase.tsx
@@ -39,7 +39,7 @@ const ContractBoxBase = ({
     theme: { colors },
   } = useStyles(styleSheet, {});
 
-  const IconView = ({ onPress, name, size, testID }: IconViewProps) => (
+  const renderIconView = ({ onPress, name, size, testID }: IconViewProps) => (
     <Pressable style={styles.icon} onPress={onPress} testID={testID}>
       <Icon color={colors.icon.alternative} name={name} size={size} />
     </Pressable>
@@ -78,20 +78,19 @@ const ContractBoxBase = ({
         )}
       </View>
       <View style={styles.iconContainer}>
-        <IconView
-          onPress={onCopyAddress}
-          name={IconName.Copy}
-          size={IconSize.Lg}
-          testID={COPY_ICON_TEST_ID}
-        />
-        {hasBlockExplorer && (
-          <IconView
-            name={IconName.Export}
-            onPress={onExportAddress}
-            size={IconSize.Md}
-            testID={EXPORT_ICON_TEST_ID}
-          />
-        )}
+        {renderIconView({
+          onPress: onCopyAddress,
+          name: IconName.Copy,
+          size: IconSize.Lg,
+          testID: COPY_ICON_TEST_ID,
+        })}
+        {hasBlockExplorer &&
+          renderIconView({
+            onPress: onExportAddress,
+            name: IconName.Export,
+            size: IconSize.Md,
+            testID: EXPORT_ICON_TEST_ID,
+          })}
       </View>
     </View>
   );

diff --git a/...ary/components-temp/Contracts/ContractBoxBase/__snapshots__/ContractBoxBase.test.tsx.snap b/...ary/components-temp/Contracts/ContractBoxBase/__snapshots__/ContractBoxBase.test.tsx.snap
@@ -65,12 +65,21 @@ exports[`Component ContractBoxBase should render correctly 1`] = `
       }
     }
   >
-    <IconView
-      name="Copy"
+    <Component
       onPress={[Function]}
-      size="24"
+      style={
+        {
+          "paddingHorizontal": 6,
+        }
+      }
       testID="copy-icon"
-    />
+    >
+      <Icon
+        color="#6a737d"
+        name="Copy"
+        size="24"
+      />
+    </Component>
   </View>
 </View>
 `;