Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use make test in CI #455

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Use make test in CI #455

merged 2 commits into from
Jul 15, 2024

Conversation

currocam
Copy link
Contributor

@currocam currocam commented Jul 15, 2024

As we agreed yesterday, here's a minimal PR using make test in the CI. I have also modified the Cmake file to also run the Eidos test suite from the Eidos executable (to match previous CI).

@bhaller bhaller merged commit 8bc26b9 into MesserLab:master Jul 15, 2024
12 of 16 checks passed
@bhaller
Copy link
Contributor

bhaller commented Jul 15, 2024

Perfect, thanks @currocam!

If you want another project (lol), as you can see the macos-13 CI is failing (and always has, when I have tried it before) because conda is not installed by GitHub Actions any more on macos CI builds, starting with macos-13 (see, e.g., actions/runner-images#9262; you can find many discussions of this in Google, their decision to remove it broke a ton of builds). The weird thing is that our CI .yaml already has its own script to install conda, with a whole caching mechanism and such, so conda ought to be there even though GitHub Actions no longer installs it for us. But it isn't, apparently; I have no idea why, and debugging this kind of thing is very much not my forté. :-> If this sounds like something you can figure out, I'd appreciate the help! The issue is here: #454. But if not, no worries. Thank you very much for your help with this make test issue!

@bhaller bhaller mentioned this pull request Jul 15, 2024
@currocam
Copy link
Contributor Author

I've done some work git GitHub Actions before, so I might give it a try!

Perfect, thanks @currocam!

If you want another project (lol), as you can see the macos-13 CI is failing (and always has, when I have tried it before) because conda is not installed by GitHub Actions any more on macos CI builds, starting with macos-13 (see, e.g., actions/runner-images#9262; you can find many discussions of this in Google, their decision to remove it broke a ton of builds). The weird thing is that our CI .yaml already has its own script to install conda, with a whole caching mechanism and such, so conda ought to be there even though GitHub Actions no longer installs it for us. But it isn't, apparently; I have no idea why, and debugging this kind of thing is very much not my forté. :-> If this sounds like something you can figure out, I'd appreciate the help! The issue is here: #454. But if not, no worries. Thank you very much for your help with this make test issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants