This repository has been archived by the owner on Nov 28, 2024. It is now read-only.
Add a --keep-message option to avoid editing pull request messages. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to address issue Mergifyio#108 — it streamlines a bit refreshing an already-created pull request.
|
Note: I'm about to add a commit to this that is not relevant to the issue at all, to make sure it works right ;) |
|
Yeah this worked fine for my needs. |
sileht
reviewed
Apr 13, 2020
pyproject.toml
Outdated
| @@ -0,0 +1,8 @@ | |||
| [build-system] | |||
There was a problem hiding this comment.
Looks unrelated to the change. Why not
There was a problem hiding this comment.
use_scm_version=True seems missing in the new configuration
There was a problem hiding this comment.
It is unrelated, see my previous comment about trying this out :)
As for use_scm_version — that is not needed when using pyproject.toml: https://github.com/pypa/setuptools_scm/#pyprojecttoml-usage
|
Can we tweak the build system in a different PR? |
Done. |
jd
approved these changes
Apr 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address issue #108 — it streamlines a bit refreshing an
already-created pull request.