Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: replace black and flake8 by ruff #89

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

jd
Copy link
Member

@jd jd commented Dec 13, 2024

No description provided.

Change-Id: I62144025c8b28e8a72bac1f67d611a84a0ae0eb0
@jd jd force-pushed the devs/jd/ruff/I62144025c8b28e8a72bac1f67d611a84a0ae0eb0 branch from abf5471 to 9215cbd Compare December 13, 2024 20:58

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we enable more rules than the default ones?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a list of good ones?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. But the default list is quite short. It should replace the former linters at least:

  • flake8
  • flake8-import-order
  • flake8-blind-except
  • flake8-builtins
  • flake8-docstrings
  • flake8-rst-docstrings
  • flake8-logging-format

@mergify mergify bot merged commit 680eb24 into main Dec 16, 2024
9 checks passed
@mergify mergify bot deleted the devs/jd/ruff/I62144025c8b28e8a72bac1f67d611a84a0ae0eb0 branch December 16, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants