-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CODECOV_TOKEN to fix code coverage uploads #298
Conversation
@jdblischak Should we just run |
965aa08
to
234db85
Compare
It's working now: https://app.codecov.io/github/Merck/simtrial/commit/31186de5ec7467151d27a72f9eb357814574112c Ready for review! |
I think using https://github.com/Merck/simtrial/actions/runs/12057397402/job/33621935217?pr=298#step:6:18
And when I go to the coverage report for this PR, https://app.codecov.io/gh/Merck/simtrial/pull/298, I see the banner message "Your org no longer requires upload tokens. You can upload without a token. Contact your admins to manage the global upload token settings." This is super frustrating. We went months without producing coverage reports, we finally properly fixed it by registering an upload token, and then they decided to roll back this requirement. And I can't find any recent blog post or documentation to accompany the banner announcement. Anyways, we already went through the effort to add |
Or maybe not! Despite the banner message saying a token is no longer required, on my other PR #303, the coverage had previously been uploaded (https://app.codecov.io/gh/Merck/simtrial/pull/303), but then today I got the expected rate limiting message. So yes, let's definitely merge this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @jdblischak !
Our code coverage results have not been uploaded for months because we aren't using a Codecov token. We were recently provided a single repository upload token for the gsDesign2 repository by the Merck open source team. Once it is added as a repository secret named
CODECOV_TOKEN
, our workflow will start uploading coverage results again.xref: r-lib/actions#834, Merck/gsDesign2#489