-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get ratio
as an attributes of sim_pw_surv
and pass it to wlr
#281
Merged
LittleBeannie
merged 7 commits into
main
from
279-get-ratio-as-an-attributes-of-sim_pw_surv-and-pass-it-to-wlr
Sep 17, 2024
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1b7ebe9
add attributes to `sim_pw_surv`
LittleBeannie afeebe9
add ratio attributes to 2 cutting functions
LittleBeannie cf85f83
add ratio attributes to counting process
LittleBeannie 9562575
get ratio from attributes in wlr
LittleBeannie 09e1848
add examples as new feature testing
LittleBeannie c9620d3
update `wlr.counting_process` following the unsuccessful test in `tes…
LittleBeannie c61aecd
fix warnings of missing @param
LittleBeannie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we please convert this example to an automated test so that we can confirm that manually providing
ratio = 2
returns a different result compared to using the empirical ratio viaratio = NULL
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @jdblischak, I appreciate you bringing this to my attention. I completely agree with you that adding tests is valuable and advantageous. But I tentatively prefer to keep it as it is. My reasons are listed as follows.
First of all, since there is no equivalence between the one with
ratio=2
andratio=NULL
, it's challenging to compare these two on the same scale.Second, rather than composing my own developer tests, I should seek volunteers for independent or double programming tests, which hold more value and solidity compared to my basic developer tests.
Third, instead of including the above in the tests, I would rather keep them as examples in the help page, where users can readily distinguish the two ways to set
ratio
, even if they don't review the test files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add the tests in a follow-up PR
I don't understand the issue with the scale. I am requesting a test that confirms that the newly added argument
ratio
has an effect on the results. Thus something like the below would be sufficient:I do not understand this perspective. The potential for better tests in the future does not remove the requirement for basic developer tests. Tests are our best method to prevent the accumulation of technical debt. As a concrete, recent example, the argument
ratio
ofgsDesign2::fixed_design_mb()
had no effect because it was not passed to the downstream sub-functions (Merck/gsDesign2#463). A basic developer test could have caught this.I was not requesting that the examples be removed. I completely agree with you that the examples section is the correct place to document this for end users. My request was to use these examples as the basis for automated tests.