Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run code conditionally to pass noSuggests check #245

Merged
merged 7 commits into from
May 3, 2024
Merged

Conversation

nanxstats
Copy link
Collaborator

Closes #243

This PR fixes the noSuggests check errors, by running code examples, tests, and vignettes conditionally, following the extrachecks recipe.

Now there are only two check notes when running the noSuggests check:

Packages suggested but not available for checking:
  'covr', 'dplyr', 'ggplot2', 'gsDesign', 'gsDesign2', 'gt',
  'survMisc', 'survRM2', 'tidyr'
* checking Rd cross-references ... NOTE
Package unavailable to check Rd xrefs: ‘gsDesign’

which I think are acceptable given they are direct benign side effects of not having Suggests packages installed when doing the check.

To run the noSuggests check locally, use R CMD check without any Suggests packages installed (except for knitr, rmarkdown, testthat) and set environment variable _R_CHECK_FORCE_SUGGESTS_=FALSE. I also used the GitHub Actions workflow mentioned in the extrachecks recipe and got consistent results.


Also updated NEWS.md and bumped version number to 0.4.1.

Copy link
Collaborator

@LittleBeannie LittleBeannie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nanxstats nanxstats merged commit fbd58a1 into main May 3, 2024
7 checks passed
@nanxstats nanxstats deleted the no-suggests branch May 3, 2024 13:53
@nanxstats nanxstats self-assigned this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass noSuggests check
2 participants