Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the file extension dictionary to include commonly used files with extensions like
.stan
thus fixes #20 .Impact
Now you should be able to use the regular
collate(..., file_auto("inst/"))
andcollate(..., file_root_core())
calls and see the.stan
files and configuration files defined by use_rstan() collated and tagged as text files.Metrics
I calculated the coverage percentage by number of files in all source packages on CRAN (data):
Before patch: 88.85%. After patch: 96.65%.
Next step
A more fundamental fix for such issues is separating file capture rules and file type tagging rules, to make the former NOT file extension-based and much more generic (via updating the current file spec definitions), and the latter universal (via dictionary + tagging all unknown extensions as binary). This will be done in issue #18.