Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using defaultColDef to fix the bug for reactR >= 0.6.0 #67

Merged
merged 3 commits into from
Dec 21, 2024

Conversation

elong0527
Copy link
Collaborator

@elong0527 elong0527 commented Dec 21, 2024

Fixes #65

The root cause of the issue is using defaultColDef with a SharedData object defined by crosslink.

Fix the issue by just avoiding using the defaultColDef because every column has been defined and reactable2 is an internal function

@nanxstats nanxstats changed the title avoid using defaultColDef to fix the bug for new reactR version Avoid using defaultColDef to fix the bug for reactR >= 0.6.0 Dec 21, 2024
Copy link
Collaborator

@nanxstats nanxstats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit surprised that this is the culprit but also not too surprised. Glad to see it's a simple fix!

@nanxstats nanxstats merged commit 217216d into main Dec 21, 2024
7 checks passed
@nanxstats nanxstats deleted the reactR-version branch December 21, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plots are not displayed on the package web site
2 participants