Issue735/bailfilter #815
Merged
Issue735/bailfilter #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes #735 . |
DeKleineKobini
requested changes
Nov 5, 2024
There was a problem hiding this comment.
From your screenshot, it seems so packed with this added, so I'm requesting a review from the other collaborator as well.
As mentioned in the contributing guide, you are missing the changelog entry and you aren't in the team.js file yet either.
…bail filter + name updated timeMatch -> timeText
|
do you think it might be better if it was under the faction filter? |
Rather than grouping up filters, I have added code for making the filters wrap. Currently, only Auction House Filter and this new Jail Filter will be affected by this change. |
Sashank999
requested changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bail cost for jail filter #735
added a bail cost filter in the jail filter
modified the existing code in ttJailFilter.js to have a new textbox for bail cost filter.