fix: Exclude location fields when api_type
is BULK
#51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation of the tap, fields described with
type=address
are correctly excluded when usingapi_type=BULK
.Although, this is not the case for geolocation fields (described with
type=location
).I'm not a Salesforce specialist per se, but know that the changes I'm applying on this branch solved the issue described here.
In my specific case I had a field like this:
As it's a compound field, split over multiple properties (
longitude
andlatitude
), the parent fieldGeolocation__c
does not have much value as the relevant information is propagated in the "sub-fields" (latitude
andlongitude
).So what I'm doing in this PR is to ensure that:
Geolocation__c
is marked withunsupported
in the schema metadata (snippet below) while still ensuring that the "sub-fields" are correctly queried.Snippet of the excluded schema after this PR:
Snippet of the "sub-fields" in the schema: