Load BLKs with mekbays, not just mechbays #6178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6178 +/- ##
=========================================
Coverage 29.17% 29.17%
Complexity 13971 13971
=========================================
Files 2628 2628
Lines 266581 266564 -17
Branches 47582 47575 -7
=========================================
- Hits 77772 77771 -1
+ Misses 184926 184910 -16
Partials 3883 3883 ☔ View full report in Codecov by Sentry. |
IllianiCBT
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MegaMek/megameklab#1632.
The Mek refactor causes DropShips to save with MekBays, but BlkFiles can only be loaded with MechBays. This fixes that.